Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Explorer crashes by going to the save-button of metadata #5337

Closed
nvaccessAuto opened this issue Sep 9, 2015 · 12 comments · Fixed by #10153
Closed

Windows Explorer crashes by going to the save-button of metadata #5337

nvaccessAuto opened this issue Sep 9, 2015 · 12 comments · Fixed by #10153

Comments

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Sep 9, 2015

Reported by The_Dark_Man on 2015-09-09 15:08
When I am in the Windows Explorer on a file with metadata and push the tab key I go through the Metadata Interpret, genre and so on. After this, there is “save” and “cancel”. When I tab on “save”, the windows explorer crashes. It’s closed. This bug is in NVDA 2015.3 new. I think, this isn’t correct. I had this problem with a mp3-file, for example. I use Windows 7 Professional. I tried it with NVDA 2015.2 ant there was no problem.

@nvaccessAuto
Copy link
Author

@nvaccessAuto nvaccessAuto commented Sep 15, 2015

Comment 1 by bdorer on 2015-09-15 20:45
He is using list view and has the explorer sidebar enabled. I don't know wheather @jteh had any other questions. Is anyone able to reproduce this? I'm not able to reproduce with win10.
Sidenote: the crash occours with other files such as excel tables and goes away sometimes if you maximize the window.

@ehollig
Copy link
Collaborator

@ehollig ehollig commented Aug 20, 2017

I am not able to replicate this using Windows 10 either. Is anyone able to test using Windows 8.1 or Windows 7?

@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented Aug 21, 2017

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Dec 10, 2018

@Brian1Gaff is this still reproducible with NVDA 2018.4 RC1?

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Feb 2, 2019

@The_Dark_Man

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Feb 2, 2019

Ok the author is not available anymore and we didn't hear for a very long time any updates. I didn't see this issue ever and it seems we cannto reproduce it. Closing.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 2, 2019

I am able to reproduce it on Windows 7 Pro x64 with latest NVDA Alpha snapshot. @Adriani90 Can you reopen please?

@leonardder leonardder reopened this Feb 2, 2019
@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 2, 2019

I am attaching log from the crash, and the dump generated from crashed explorer. Note that when the crash occurred NVDA freezes for about 5 minutes.
issue_5337.zip

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 11, 2019

It looks like it is enough to tab to any metadata field and then try shift+tabbing back to cause this crash to happen. I understand that Windows 7 isn't the latest and greatest, but this is very serious, entire system is not responsive for about 5 minutes after this. @michaelDCurran @feerrenrut Any chance for fixing this? I've attached dump above, but if any additional info would be needed just let me know.

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Feb 11, 2019

Looks like Windows is prematurely freeing the memory of a richEdit document object before the COM subsystem tries to. That is most definitely a bad programming error on the Windows side. I doubt there is anything we can do on the NVDA side a part from some how black listing that control making it completely inaccessible. Even that may not be enough as it is possible that the UI Automation core library is the one accessing that control, not necessarily NvDA directly. This seems to be the most likely as no changes were directly made to our richEdit support between 2015.2 and 2015.3, however many UIA changes were made.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Feb 12, 2019

I've tested with UIA disabled and Windows Explorer still crashed not as severe though, NVDA freezes only for about a minute as opposed to 5.

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented Aug 27, 2019

I've bisected this and this crash was introduced by 89dd4b7

lukaszgo1 added a commit to lukaszgo1/nvda that referenced this issue Aug 27, 2019
michaelDCurran pushed a commit that referenced this issue Sep 13, 2019
…edit fields (#10153)

* Stop using ITextDocumentTextInfo for metadata fields in Win Explorer under Windows 7. Fixes #5337

* Style

* Review actions
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants