New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color not reported in RichEdit documents #5352

Closed
nvaccessAuto opened this Issue Sep 11, 2015 · 9 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto

nvaccessAuto commented Sep 11, 2015

Reported by norrumar on 2015-09-11 19:33
STR:

  1. Open a RichEdit document, i.e. in Wordpad.
  2. Press NVDA+f.

Expected: Colors should be reorted.
Actual: Colors not reported.

Technical:

  • Current TextInfo: TextInfo: <class 'NVDAObjects.window.edit.ITextDocumentTextInfo'>
  • TextInfo in NVDA 2015.2:
    TextInfo: <class 'NVDAObjects.window.edit.EditTextInfo'>
@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 12, 2015

Comment 2 by jteh on 2015-09-12 03:25
Just to confirm, you're saying this did work in NVDA 2015.2, right?

nvaccessAuto commented Sep 12, 2015

Comment 2 by jteh on 2015-09-12 03:25
Just to confirm, you're saying this did work in NVDA 2015.2, right?

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 12, 2015

Comment 3 by norrumar (in reply to comment 2) on 2015-09-12 06:34
Replying to jteh:

Just to confirm, you're saying this did work in NVDA 2015.2, right?

Yes: it does work in NVDA 2015.2, but not in 2015.3.
Thanks.

nvaccessAuto commented Sep 12, 2015

Comment 3 by norrumar (in reply to comment 2) on 2015-09-12 06:34
Replying to jteh:

Just to confirm, you're saying this did work in NVDA 2015.2, right?

Yes: it does work in NVDA 2015.2, but not in 2015.3.
Thanks.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 12, 2015

Comment 4 by briang1 on 2015-09-12 08:47
Erm. I have just tried this on Wordpad, Jarte and Microsoft Word, and the command on a file set with default background and maroon text works fine in all of them in the current and last release and the next and master snaps which are up at the moment. The only difference is that Word does not say default for the background.
I used XP but unless there is some subtle way it varies between versions of Windows, then I'm really at a loss here.

nvaccessAuto commented Sep 12, 2015

Comment 4 by briang1 on 2015-09-12 08:47
Erm. I have just tried this on Wordpad, Jarte and Microsoft Word, and the command on a file set with default background and maroon text works fine in all of them in the current and last release and the next and master snaps which are up at the moment. The only difference is that Word does not say default for the background.
I used XP but unless there is some subtle way it varies between versions of Windows, then I'm really at a loss here.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Sep 13, 2015

Comment 5 by jteh on 2015-09-13 12:01
Yeah; we didn't change to using ITextDocument for XP, because in XP, ITextDocument is ridiculously slow. See #4291.

nvaccessAuto commented Sep 13, 2015

Comment 5 by jteh on 2015-09-13 12:01
Yeah; we didn't change to using ITextDocument for XP, because in XP, ITextDocument is ridiculously slow. See #4291.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 22, 2015

Comment 6 by Michael Curran <mick@... on 2015-10-22 02:24
In commit 9263160:
Merge branch 't5352' into next. Incubates #5352
Changes:
Added labels: incubating

nvaccessAuto commented Oct 22, 2015

Comment 6 by Michael Curran <mick@... on 2015-10-22 02:24
In commit 9263160:
Merge branch 't5352' into next. Incubates #5352
Changes:
Added labels: incubating

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Oct 23, 2015

Comment 7 by jteh on 2015-10-23 04:42
Changes:
Milestone changed from None to 2016.1

nvaccessAuto commented Oct 23, 2015

Comment 7 by jteh on 2015-10-23 04:42
Changes:
Milestone changed from None to 2016.1

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 1, 2015

Comment 8 by jteh on 2015-11-01 22:20
Actually, this should be pretty safe and it's a regression from 2015.2, so we'll take it for 2015.4.
Changes:
Milestone changed from 2016.1 to 2015.4

nvaccessAuto commented Nov 1, 2015

Comment 8 by jteh on 2015-11-01 22:20
Actually, this should be pretty safe and it's a regression from 2015.2, so we'll take it for 2015.4.
Changes:
Milestone changed from 2016.1 to 2015.4

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 1, 2015

Comment 9 by norrumar (in reply to comment 8) on 2015-11-01 23:03
Replying to jteh:

Actually, this should be pretty safe and it's a regression from 2015.2, so we'll take it for 2015.4.

Thanks, if it's possible, I will be grateful since in my job it's used a program with richedit documents, and I need to be sure about the color of the text inside this application.
Cheers.

nvaccessAuto commented Nov 1, 2015

Comment 9 by norrumar (in reply to comment 8) on 2015-11-01 23:03
Replying to jteh:

Actually, this should be pretty safe and it's a regression from 2015.2, so we'll take it for 2015.4.

Thanks, if it's possible, I will be grateful since in my job it's used a program with richedit documents, and I need to be sure about the color of the text inside this application.
Cheers.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto Nov 9, 2015

Comment 10 by James Teh <jamie@... on 2015-11-09 00:05
In commit 927095c:
Add support for reporting colors to ITextDocument (RichEdit).

Fixes #5352.
Changes:
Removed labels: incubating
State: closed

nvaccessAuto commented Nov 9, 2015

Comment 10 by James Teh <jamie@... on 2015-11-09 00:05
In commit 927095c:
Add support for reporting colors to ITextDocument (RichEdit).

Fixes #5352.
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.4 milestone Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 11, 2015

jcsteh added a commit that referenced this issue Nov 25, 2015

Revert "Back out new translatable string accidentally introduced with…
… merge of #5352 until after 2015.4 freeze."

The 2015.4 freeze is done, so we can now put this back.
This reverts commit a9e3b9f.
Fixes #5474.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment