Reported by jteh on 2015-10-30 06:43
@tspivy noted that failing to call super in a plug-in constructor completely breaks all script handling where the plug-in is queried. For global plug-ins, this means the entirety of NVDA.
I haven't tested this myself, but it makes sense. The ScriptableObject constructor is what sets _gestureMap and getScript assumes this is present. We should probably catch and log exceptions when calling gesture.script in InputManager.executeGesture, since we really don't want that method throwing exceptions.
The text was updated successfully, but these errors were encountered:
Reported by jteh on 2015-10-30 06:43
@tspivy noted that failing to call super in a plug-in constructor completely breaks all script handling where the plug-in is queried. For global plug-ins, this means the entirety of NVDA.
I haven't tested this myself, but it makes sense. The ScriptableObject constructor is what sets _gestureMap and getScript assumes this is present. We should probably catch and log exceptions when calling gesture.script in InputManager.executeGesture, since we really don't want that method throwing exceptions.
The text was updated successfully, but these errors were encountered: