Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to call super in plug-in constructor breaks script handling #5446

Closed
nvaccessAuto opened this issue Oct 30, 2015 · 2 comments · Fixed by #11166
Closed

Failing to call super in plug-in constructor breaks script handling #5446

nvaccessAuto opened this issue Oct 30, 2015 · 2 comments · Fixed by #11166
Labels
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-10-30 06:43
@tspivy noted that failing to call super in a plug-in constructor completely breaks all script handling where the plug-in is queried. For global plug-ins, this means the entirety of NVDA.

I haven't tested this myself, but it makes sense. The ScriptableObject constructor is what sets _gestureMap and getScript assumes this is present. We should probably catch and log exceptions when calling gesture.script in InputManager.executeGesture, since we really don't want that method throwing exceptions.

@leonardder
Copy link
Collaborator

I'd say a p3 is ok for this, as this is causing problems for external contributions only? cc @jcsteh @michaelDCurran

@michaelDCurran
Copy link
Member

Gave it a p3. Although serious when it happens, the developer of the plugin would have surely noticed it when developing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants