Skip to content

Failing to call super in plug-in constructor breaks script handling #5446

Closed
@nvaccessAuto

Description

@nvaccessAuto

Reported by jteh on 2015-10-30 06:43
@tspivy noted that failing to call super in a plug-in constructor completely breaks all script handling where the plug-in is queried. For global plug-ins, this means the entirety of NVDA.

I haven't tested this myself, but it makes sense. The ScriptableObject constructor is what sets _gestureMap and getScript assumes this is present. We should probably catch and log exceptions when calling gesture.script in InputManager.executeGesture, since we really don't want that method throwing exceptions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions