New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock keys double announce when Speak command keys is on #5490

Closed
ObjectInSpace opened this Issue Nov 14, 2015 · 4 comments

Comments

Projects
None yet
5 participants
@ObjectInSpace

ObjectInSpace commented Nov 14, 2015

Use Insert 2 and insert 4 to activate "speak typed characters" and "speak command keys." Then hit a "locking" key (caps, num, or scroll.) NVDA will say the name of the key, then the name of the key again, and then its state. Pressing caps lock, for example, will cause NVDA to say "caps lock, caps lock on."

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Nov 14, 2015

Contributor

If someone wants to take a stab at this, it should just be a matter of making KeyboardInputGesture.shouldReportAsCommand return False for caps lock.

Contributor

jcsteh commented Nov 14, 2015

If someone wants to take a stab at this, it should just be a matter of making KeyboardInputGesture.shouldReportAsCommand return False for caps lock.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Nov 14, 2015

Collaborator

Hi,

Are there other toggle commands that should be taken care of in addition to caps lock? Thanks.

From: James Teh [mailto:notifications@github.com]
Sent: Friday, November 13, 2015 9:38 PM
To: nvaccess/nvda nvda@noreply.github.com
Subject: Re: [nvda] lock keys double announce when speak typed characters and command keys are on (#5490)

If someone wants to take a stab at this, it should just be a matter of making KeyboardInputGesture.shouldReportAsCommand return False for caps lock.


Reply to this email directly or view it on GitHub #5490 (comment) .

Collaborator

josephsl commented Nov 14, 2015

Hi,

Are there other toggle commands that should be taken care of in addition to caps lock? Thanks.

From: James Teh [mailto:notifications@github.com]
Sent: Friday, November 13, 2015 9:38 PM
To: nvaccess/nvda nvda@noreply.github.com
Subject: Re: [nvda] lock keys double announce when speak typed characters and command keys are on (#5490)

If someone wants to take a stab at this, it should just be a matter of making KeyboardInputGesture.shouldReportAsCommand return False for caps lock.


Reply to this email directly or view it on GitHub #5490 (comment) .

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Nov 14, 2015

Contributor
Contributor

jcsteh commented Nov 14, 2015

@jcsteh jcsteh changed the title from lock keys double announce when speak typed characters and command keys are on to Lock keys double announce when Speak command keys is on Apr 28, 2016

feerrenrut added a commit that referenced this issue Jun 7, 2016

Fix issue #5490 - lock keys double announce
Issue: Lock keys double announce when Speak command keys is on
#5490

Added a special case to _get_shouldReportAsCommand if the key
is in the TOGGLE_KEYS list.
@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jun 15, 2016

Contributor

Incubated in f0e78d7.

Contributor

jcsteh commented Jun 15, 2016

Incubated in f0e78d7.

@feerrenrut feerrenrut self-assigned this Jun 16, 2016

feerrenrut added a commit that referenced this issue Jul 11, 2016

Update changes list for #5490
No longer double announce lock keys when Speak command keys is on. (#5490)

@jcsteh jcsteh added this to the 2016.3 milestone Aug 5, 2016

@feerrenrut feerrenrut removed their assignment Aug 8, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment