Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Elements list filter when changing element type #5511

Closed
Qchristensen opened this Issue Nov 19, 2015 · 5 comments

Comments

Projects
None yet
4 participants

After bringing up the elements list (NVDA+f7) and entering text in the filter box, if you then change type (eg between links, headings and landmarks), the list of elements resets to show an unfiltered list of the new element type, however the original filter text is still left in the filter edit box.

@jcsteh jcsteh added this to the 2016.1 milestone Nov 19, 2015

Contributor

jcsteh commented Nov 19, 2015

Implementation note: The filter field should simply be cleared when we switch to (initialise) a different element type.

Collaborator

derekriemer commented Nov 19, 2015

This behavior could be useful if someone realized they were looking for
a heading titled fish tacos rather than a link titled fish tacos. Just
thought I would note.

On 11/18/2015 6:14 PM, James Teh wrote:

Implementation note: The filter field should simply be cleared when we
switch to (initialise) a different element type.


Reply to this email directly or view it on GitHub
#5511 (comment).


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.drupalgardens.com
Non-proffessional website. http://derekriemer.pythonanywhere.com/personal
Awesome little hand built weather app that rocks!
http://derekriemer.pythonanywhere.com/weather

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

Contributor

jcsteh commented Nov 19, 2015

@dkager dkager added a commit to dkager/nvda that referenced this issue Nov 19, 2015

@dkager dkager In the Elements List in Browse Mode, clear the filter text when switc…
…hing element types. Fixes #5511.
7fe825e

@jcsteh jcsteh self-assigned this Nov 20, 2015

@jcsteh jcsteh added a commit that referenced this issue Nov 26, 2015

@dkager @jcsteh dkager + jcsteh In the Elements List in browse mode, when you change the type of elem…
…ent, the Filter by field is now cleared.


Fixes #5511.
6a4e665

Incubated in b8ac268.

Incubated in f392e5a.

@jcsteh jcsteh closed this in 2df1a81 Dec 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment