New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow NVDA compilation using MSVC 2015 #5592

Closed
michaelDCurran opened this Issue Dec 7, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@michaelDCurran
Contributor

michaelDCurran commented Dec 7, 2015

Currently NVDA can only be compiled with Microsoft Visual c++ 2012 update 3 or higher, or Microsoft Visual C++ 2013. We should support compiling with Microsoft Visual C++ 2015. This requires Scons 2.4.1 and multiple fixes to our source code as VC 2015 is much more pickier about casting truncation on 64 bit (specifically in regards to HWND and HANDLE).

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Dec 7, 2015

Incubated in 5d76183.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Dec 22, 2015

Contributor

The current deployment plan for this is:

  • In early January, install VS 2015 on our build server.
  • Once VS 2015 is installed, force the VS version to 2015 so NVDA will refuse to build at all with earlier versions. This should be merged into next.
  • NVDA 2016.1 (and thus master until rc) will still be VS 2012.
  • Merge to master at the start of the 2016.2 release cycle (after 2016.1rc1).
Contributor

jcsteh commented Dec 22, 2015

The current deployment plan for this is:

  • In early January, install VS 2015 on our build server.
  • Once VS 2015 is installed, force the VS version to 2015 so NVDA will refuse to build at all with earlier versions. This should be merged into next.
  • NVDA 2016.1 (and thus master until rc) will still be VS 2012.
  • Merge to master at the start of the 2016.2 release cycle (after 2016.1rc1).

@michaelDCurran michaelDCurran added this to the 2016.2 milestone Jan 5, 2016

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Jan 6, 2016

Incubated in a74f6c2.

@nvaccessAuto

This comment has been minimized.

Show comment
Hide comment
@nvaccessAuto

nvaccessAuto commented Feb 5, 2016

Incubated in d287eef.

@nvaccessAuto nvaccessAuto removed the incubating label Mar 2, 2016

@jcsteh jcsteh closed this in 838973b Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment