Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for Eclipse #5667

Closed
francipvb opened this issue Jan 10, 2016 · 9 comments

Comments

@francipvb
Copy link
Contributor

commented Jan 10, 2016

Hi,

I made some modifications to the AppModule for the Eclipse IDE.

It's to allow using the autocompletion feature without leaving the focus from the code editor.

eclipse_appModule_patch.txt

It's a patch file.

Cheers.

@dkager

This comment has been minimized.

Copy link
Collaborator

commented Jan 13, 2016

+class autocompletionItem(IAccessible):

Following code semantics, the class should probably be called AutocompletionItem (with capital A).

+       # Fixme: I don't know if it is the correct way to do this.
+       ui.message(self.name)

With default configuration this will show the message in braille for only a few seconds. If I remember correctly Eclipse doesn't pop up a proper context menu for these suggestions, so this solution may be the next best thing. Still, if it is actually a list that stays on screen for the programmer to ponder over it'd be nice if NVDA could interpret it as such. Would it not be possible to auto-focus this thing when it appears? Just some uneducated guesses...

@francipvb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2016

Hello,

El 13/01/2016 a las 07:23 a.m., Davy Kager escribió:

+class autocompletionItem(IAccessible):

Following code semantics, the class should probably be called
AutocompletionItem (with capital A).

Yes, I did read the code semantics after posting it.

  * # Fixme: I don't know if it is the correct way to do this.
  * ui.message(self.name)

With default configuration this will show the message in braille for
only a few seconds. If I remember correctly Eclipse doesn't pop up a
proper context menu for these suggestions, so this solution may be the
next best thing. Still, if it is actually a list that stays on screen
for the programmer to ponder over it'd be nice if NVDA could interpret
it as such. Would it not be possible to auto-focus this thing when it
appears? Just some uneducated guesses...

Anyway, I noticed some problems dealing with it in this way. For
example, if you are at a longer line, you need to wait the synthesizer
finish reading it before start reading the selected suggestion.

Additionally, this script actually doesn't support the XML
Autocompleter, for example.

I think that it can be better sending a fake gainFocus event or stopping
the speech before it can be read.

I'll test these alternatives and then I'll post a pull request.

P.D: Sorry, my English is too bad.

Cheers,

¡Cuando tus fuerzas terminan, las de Dios comienzan!

@francipvb

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2016

Hello,

I believe that it's solved. Please test it and reopen this isswe if you have problems.

Cheers,

@josephsl

This comment has been minimized.

Copy link
Collaborator

commented Jan 14, 2016

Hi,
Please don't close an issue just because you think it is closed (this patch requires further user testing).
An issue should be closed if:

  1. This is a duplicate of an existing issue.
  2. A setting change has fixed na issue.
  3. Officially included in a release version of NVDA (inclusion into master means it is definitely included in the next version).
    If ther's a way to reopen this...
    Thanks.

@josephsl josephsl reopened this Jan 14, 2016

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Oct 31, 2017

feerrenrut added a commit that referenced this issue Oct 31, 2017

@feerrenrut

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2017

The change associated with issue has been reverted. Re-opening this issue. The change caused an error to be raised in some circumstances please see #5680 (comment) for further details.

@feerrenrut feerrenrut reopened this Nov 1, 2017

@feerrenrut feerrenrut removed this from the 2017.4 milestone Nov 1, 2017

@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2019

are there any further alternatives planed to solve this issue? @feerrenrut mybe we can get some further suggestions from @albzan who created an eclipse addon? @albzan are you planning to raise any pull requests with improvements?

@francipvb

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

Hello,

I'm tweaking this a little...

Sorry for the huge delay.

@francipvb

This comment has been minimized.

Copy link
Contributor Author

commented Feb 19, 2019

Hello,

Please check #9297.

cheers,

@albzan

This comment has been minimized.

Copy link

commented Feb 23, 2019

are there any further alternatives planed to solve this issue? @feerrenrut mybe we can get some further suggestions from @albzan who created an eclipse addon? @albzan are you planning to raise any pull requests with improvements?

Yep, I'm open for contributions and, too, if someone want to help improve it and submit to the addon community site.
For the automatic announcement of the dialog, I think it should be annoying because it will be repeated for each letter you enter. I've developed a version where when the pop-up comes up the addon makes a sound.
What do you think of this implementation?

@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.