Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'report balloons' option' with 'report balloons and toast/other notifications' #5789

Closed
JamaicanUser opened this issue Mar 2, 2016 · 3 comments
Labels
Milestone

Comments

@JamaicanUser
Copy link

@JamaicanUser JamaicanUser commented Mar 2, 2016

To my knowledge, help balloons are not used in Windows 8 and later. So, it would be confusing, especially to a new user of Windows, to have this option on in that instance on Windows 8 and later. However, this results in the toasts not being read. For that, I recommend a change of the option name to reflect this variation.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Mar 2, 2016

H, I agree (quite trivial to implement, I’d say a new dev should do it).

From: JamaicanUser [mailto:notifications@github.com]
Sent: Wednesday, March 2, 2016 12:52 PM
To: nvaccess/nvda nvda@noreply.github.com
Subject: [nvda] replace 'report balloons' option' with 'report balloons and toast/other notifications' (#5789)

To my knowledge, help balloons are not used in Windows 8 and later. So, it would be confusing, especially to a new user of Windows, to have this option on in that instance on Windows 8 and later. However, this results in the toasts not being read. For that, I recommend a change of the option name to reflect this variation.


Reply to this email directly or view it on GitHub #5789 .

@jcsteh jcsteh added the goodForNewDev label Mar 2, 2016
@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Mar 2, 2016

I think we should possibly just name it "Report notifications" or similar, which covers both. The config option should not be renamed internally, though, so as to avoid breaking backwards compat.

@fisher729
Copy link

@fisher729 fisher729 commented Aug 2, 2017

Hi.

Any updates on this ticket. It might be easy to fix, but it hasn't been looked at as yet...

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Aug 13, 2018
feerrenrut added a commit that referenced this issue Aug 13, 2018
Change report balloons to report notifications.
Fixes #5789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants