New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option "Enable Braille message timeout" #5882
Comments
|
Hi, @nishimotz: can we work on a way to pull in your team’s diffs if this feature is accepted? Thanks. From: surfer0627 [mailto:notifications@github.com] In NVDA_JP (language settings), there is an option called "Enable Braille message timeout". 5.2.11. Enable Braille message timeout — |
|
If it really does just set a long timeout, why wouldn't a user just enter a long timeout (rather than having a separate option)? If there is a good use case for having a true "forever" setting, I think we can do far better in terms of UX. I think "Disable message timeout" isn't going to make sense to many users.
|
|
The 'forever' setting is necessary for input composition and/or character descriptions. I wanted to make the setting file of NVDAJP compatible with the original version. Actually I don't like the solution so far, because I understand ui.message should be volatile. |
|
From what I can see, NVDAObjects.behaviors.CandidateItem uses
properties to present candidates, not ui.message. Is there somewhere
else in our code that uses ui.message for candidates or is this NVDAJP
code? If NVDAJP code, is there any reason you're not using (or at least
deriving from) the input composition support in NVDA core, including the
CandidateItem behaviour?
CC @michaelDCurran.
|
|
For example, NVDAHelper.handleInputCandidateListUpdate uses ui.message for candidate items list. |
|
Ah. I see ui.message is used there, but that's only to report all the
candidates initially to give the user an overview of the candidates. I
don't follow why you'd want that to stay on the display forever, though,
since you have to navigate to a candidate before you can select it.
Also, why is autoReportAllCandidates unsuitable for Japanese?
|
Now, the maximum message timeout is "20" seconds. Sometimes, it's not enough for users press numpad2 twice to read "character descriptions". The reason why I request to add an option, because this feature is based on code from NVDA_JP. It sounds like a time-saving solution. |
|
Regarding input composition, another point is I have reviewed past discussion in Japanese community and learned as follows:
@surfer0627 |
|
I don't think the argument for messages while away from the computer
justifies this, as even for sighted users, most pop-up style
notifications like this disappear after a while. If the notification was
intended to stay there the entire time, a modal dialog should have been
used.
|
|
I was requested to make a patch or 'ready to pull' version of my work, however, I would like to discuss further, before Chinese language community will make a try-build. Back to "very long Braille message timeout," just allowing a long timeout seemed nicer, in terms of user experience, as @jcsteh mentioned. As I wrote previously, the reason of my design was compatibility of nvda.ini file. The Braille.messageTimeout is defined as follows: If forked version of NVDA allows the bigger values for this parameter, the modified nvda.ini would raise validation error with the original or previous version of NVDA. For example opening Braille settings dialog causes error as follows and the dialog cannot be accessed: The user profiles of NVDA may be shared with various versions of NVDA, so it would be seriously inconvenient. We cannot change the behaviors of past versions regarding this, so I thought that adding new option is safe way of doing this. Comments are welcome. |
|
We already treats the value of zero as special. If we define "Specifying 20 makes Braille message displayed forever," it won't break the profile compatibility across NVDA versions. After this change, the maximum number of the timeout will be 19 seconds. |
|
What about -1? On 8/9/2016 5:30 PM, Takuya Nishimoto wrote:
Websites: email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu |
|
I'm going to close this. It was covered by #6777. |
In NVDA_JP (language settings), there is an option called "Enable Braille message timeout".
Here is a short description from NVDAJP Release Notes 2016.1jp:
The text was updated successfully, but these errors were encountered: