Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BrailleNote: Support scroll wheel on Apex BT #5992

Closed
josephsl opened this issue May 24, 2016 · 2 comments
Closed

BrailleNote: Support scroll wheel on Apex BT #5992

josephsl opened this issue May 24, 2016 · 2 comments

Comments

@josephsl
Copy link
Collaborator

Hi,

Referencing #2012:

On the Apex BT, there exists a scroll wheel between dots 1 and 4. This consists of four directional dots, a center button and a scroll wheel.

The below commit assigns following commands:

  • Center button: ENTER.
  • Directional dots are assigned to arrow keys.
  • Scroll clockwise: TAB.
  • Scroll counterclockwise: Shift+TAB.

Also took the time to update the BN driver by modifying copyrights. Another branch will be used for providing basic support for BrailleNote QT. Thanks.
josephsl added a commit that referenced this issue May 24, 2016
@josephsl
BrailleNote: Support scroll wheel on Apex BT. re #5992
197b8d7
@josephsl josephsl mentioned this issue May 24, 2016
Closed
josephsl added a commit that referenced this issue May 24, 2016
@josephsl
BrailleNote: Various BT and QT commands now work correctly. re #5992.
1d9c92f 
Somehow, forgot to check that Rui used a tuple to specify key assignments. Now utilized properly to assign multiple gestures to a command. Also took this time to add codes for various QT keys so NVDA can properly recognize them.
@josephsl
Copy link
Collaborator Author

josephsl commented Jun 5, 2016

Hi,

#5993 portion: Working great according to two testers. I'm waiting for feedback from other Apex BT users (I use an Apex BT).

Thanks.

@josephsl josephsl mentioned this issue Aug 30, 2016
Merged
josephsl added a commit to josephsl/nvda that referenced this issue Sep 23, 2016
@josephsl
BrailleNote QT: handle QT input directly from read packet function. re …
72c6648 
…nvaccess#5992

Comment from Jamie Teh (Nv Access): there's no need to call read packet again if we're dealing with QT, so handle this from read packet directly. Thus readPacket returns three things: command, arg (dot mask on BT/command for QT), arg2 (char from QT).
josephsl added a commit to josephsl/nvda that referenced this issue Sep 27, 2016
@josephsl
User guide: cosmetics. re nvaccess#5992
58f5f9a 
Review from Jamie Teh (NV Access):
* QT can emulate a BrailleNote BT, hence clarify this.
* Removed redundant kcinclude statement.
josephsl added a commit to josephsl/nvda that referenced this issue Apr 12, 2018
@josephsl
BrailleNote: copyright year update, QT key name changes. Re nvaccess#…
5aee821 
…5992.

Commented by Leonard de Ruijter: rename QT key names.
Update copyright years.
josephsl added a commit to josephsl/nvda that referenced this issue Apr 12, 2018
@josephsl
BrailleNote: rename scroll wheel constant strings. Re nvaccess#5992.
cec3188
michaelDCurran pushed a commit that referenced this issue Jun 13, 2018
@josephsl @michaelDCurran
BrailleNote: support for QT and Apex BT scroll wheel (#6316)
30cd6b8 
* BrailleNote: Support scroll wheel on Apex BT. re #5992

* BrailleNote: Support BrailleNote QT basic mode. re #5993

* BrailleNote: Various BT and QT commands now work correctly. re #5992.

Somehow, forgot to check that Rui used a tuple to specify key assignments. Now utilized properly to assign multiple gestures to a command. Also took this time to add codes for various QT keys so NVDA can properly recognize them.

* BrailleNote QT: handle QT input directly from read packet function. re #5992

Comment from Jamie Teh (Nv Access): there's no need to call read packet again if we're dealing with QT, so handle this from read packet directly. Thus readPacket returns three things: command, arg (dot mask on BT/command for QT), arg2 (char from QT).

* BrailleNote QT: QT key parser refactor.

Instead of relying on a dedicated QT key parser, handle parsing directly in readPacket. Also simplifies gesture ID assignment, as the packet will tell the gesture constructor as to what key it is.

* BrailleNote QT: comment text change, correct ticket, simplified dictionary key lookup. re #5993

A tip from Jamie Teh (NV Access0: use dict.get to simplify the turnary operation. Also, BNQT ticket is 5993, not 5992, and correct comment text.

* User guide: cosmetics. re #5992

Review from Jamie Teh (NV Access):
* QT can emulate a BrailleNote BT, hence clarify this.
* Removed redundant kcinclude statement.

* BrailleNote QT: use set instead of worrying too much about formatting gesture identifier right. #5993

Comment from Jamie Teh (NV Access): use sets instead of turning that into a list just for formatting purposes (and turns out this is unnecessary).

* Merge master

* Readjust commands

* BrailleNote: copyright year update, QT key name changes. Re #5992.

Commented by Leonard de Ruijter: rename QT key names.
Update copyright years.

* BrailleNote: rename scroll wheel constant strings. Re #5992.

* Restore executable permission to win32calc
josephsl added a commit to josephsl/nvda that referenced this issue Jun 13, 2018
@josephsl
BrailleNote QT: no more ord(arg2) due to stringification. Re nvaccess…
1de5404 
…#5992.

Perhaps due to use of HwIO: strings are passed in, so no need to ord it anymore. This means QT commands will no longer fail to function.
@ehollig
Copy link
Collaborator

ehollig commented Aug 27, 2018

Closing this, as #6316 has been merged.

@ehollig ehollig closed this as completed Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephsl @ehollig