Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BrailleNote QT basic mode #5993

Closed
josephsl opened this issue May 24, 2016 · 6 comments

Comments

@josephsl
Copy link
Collaborator

commented May 24, 2016

Hi,

Continuing from #5992:

The below commit (part of i5992 branch) adds support for BrailleNote QT models. There are two modes of operation: basic mode (basic QWERTY commands are available), and PC mode (emulates PC keyboard).

The following commands are available:

  • NVDA menu: Alt+N
  • Control+Home: Alt+T
  • Control+End: Alt+B
  • Windows key: Alt+W
  • Alt key: Alt+M
  • Input help mode toggle: Alt+1

On the QT, the names of keys are:

  • Read: Alt
  • Control: Control
  • Function: right Alt.

QT commands are based on KeySoft native commands except as noted. Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Sep 27, 2016
BrailleNote QT: comment text change, correct ticket, simplified dicti…
…onary key lookup. re nvaccess#5993

A tip from Jamie Teh (NV Access0: use dict.get to simplify the turnary operation. Also, BNQT ticket is 5993, not 5992, and correct comment text.
josephsl added a commit to josephsl/nvda that referenced this issue Sep 29, 2016
BrailleNote QT: use set instead of worrying too much about formatting…
… gesture identifier right. nvaccess#5993

Comment from Jamie Teh (NV Access): use sets instead of turning that into a list just for formatting purposes (and turns out this is unnecessary).
@SamuelEnglard

This comment has been minimized.

Copy link

commented Feb 15, 2017

I've been playing around with the BrailleNote QT and thought it might help to let you know that the codes it sends for keys are the Windows Virtual Key Codes

michaelDCurran added a commit that referenced this issue Jun 13, 2018
BrailleNote: support for QT and Apex BT scroll wheel (#6316)
* BrailleNote: Support scroll wheel on Apex BT. re #5992

* BrailleNote: Support BrailleNote QT basic mode. re #5993

* BrailleNote: Various BT and QT commands now work correctly. re #5992.

Somehow, forgot to check that Rui used a tuple to specify key assignments. Now utilized properly to assign multiple gestures to a command. Also took this time to add codes for various QT keys so NVDA can properly recognize them.

* BrailleNote QT: handle QT input directly from read packet function. re #5992

Comment from Jamie Teh (Nv Access): there's no need to call read packet again if we're dealing with QT, so handle this from read packet directly. Thus readPacket returns three things: command, arg (dot mask on BT/command for QT), arg2 (char from QT).

* BrailleNote QT: QT key parser refactor.

Instead of relying on a dedicated QT key parser, handle parsing directly in readPacket. Also simplifies gesture ID assignment, as the packet will tell the gesture constructor as to what key it is.

* BrailleNote QT: comment text change, correct ticket, simplified dictionary key lookup. re #5993

A tip from Jamie Teh (NV Access0: use dict.get to simplify the turnary operation. Also, BNQT ticket is 5993, not 5992, and correct comment text.

* User guide: cosmetics. re #5992

Review from Jamie Teh (NV Access):
* QT can emulate a BrailleNote BT, hence clarify this.
* Removed redundant kcinclude statement.

* BrailleNote QT: use set instead of worrying too much about formatting gesture identifier right. #5993

Comment from Jamie Teh (NV Access): use sets instead of turning that into a list just for formatting purposes (and turns out this is unnecessary).

* Merge master

* Readjust commands

* BrailleNote: copyright year update, QT key name changes. Re #5992.

Commented by Leonard de Ruijter: rename QT key names.
Update copyright years.

* BrailleNote: rename scroll wheel constant strings. Re #5992.

* Restore executable permission to win32calc
@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2018

Hi,

Fixed a critical regression: possibly due to use of HwIO, QT commands were treated as raw strings, so no need to ord this anymore. Thanks.

josephsl added a commit that referenced this issue Jun 13, 2018
BrailleNote: fix ord(arg2) problem. Re #5993.
Perhaps due to HwIO: when processing QT commands (arg2), the argument was a string, not an integer, so ord(arg2) didn't work. Now fixed.
@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Feb 24, 2019

@josephsl is this issue still valid?

@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2019

@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Feb 25, 2019

ok does this mean the issue is solved? Or you will not work on this in the future. If it's not solved then maybe we can find someone who can continue working on this. Thanks.

@josephsl

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 25, 2019

@leonardder leonardder closed this Feb 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.