Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS Excel: NVDA report {color} on {backgroundColor} problem #6029

Closed
surfer0627 opened this issue Jun 2, 2016 · 9 comments
Closed

MS Excel: NVDA report {color} on {backgroundColor} problem #6029

surfer0627 opened this issue Jun 2, 2016 · 9 comments
Assignees
Milestone

Comments

@surfer0627
Copy link
Contributor

@surfer0627 surfer0627 commented Jun 2, 2016

This case occur in NVDA2015.2 and later.
STR:

  1. Open the attachment.
  2. Move to cell I6.
    Press NVDA+f
    NVDA 2015.2 report: Black on Coral
    NVDA2015.1 report: black on orange
    sighted person say: black on orange
    note: Here NVDA detect-background matches with Excel Fill Color. I just curious why sighted person say "this is black on orange". Also, it seems difficult for a blind user to know that color coral is close to orange.
  3. Move to cell F13.
    Press NVDA+f
    NVDA 2015.2 report: Black on Gold
    sighted person say: black on yellow
    note: In this case, Fill Color "orange" is selected.
@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Jun 2, 2016

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Jun 3, 2016

Another case, NVDA indicate-backgroundColor does not match with Excel Fill Color.
Fill Color: purple
NVDA: Black on Dark Orchid
NVDA 2015.1: purple

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jun 6, 2016

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jun 13, 2016

Incubated in 11382a9.

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Jun 16, 2016

Test Next13360 in Excel2010:

  1. Filled background color blue or light blue.
    NVDA got the same result "aqua-blue".
  2. Filled background color red or dark red.
    NVDA got the same result "red".
    Also, if the fill-backgroundColor name would match with the formatting info?
    E.G: fill backgroundColor purple
    formatting info: blue-purple
@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Jun 16, 2016

We have made two choices with NVDA's color support:

    1. The colors that NVDA reports will only use combinations of the
      following well-known color names: red, brown, orange, yellow, green,
      aqua, blue, purple, pink, white, grey and black. However, NVDA will also
      distinguish both dark and pale versions of these colors.
    1. Where possible, NVDA will report the closest color to what is
      actually displayed on the screen, rather than how it may be labeled in a
      specific application. For example if Excel's fill color of "orange"
      actually looks "orange-yellow" rather than orange, then the user has the
      right to know this.

I think though based on the most recent examples given by @surfer0627,
our ratios for dark and pale still need to be tweaked a little.

On 16/06/2016 1:18 PM, surfer0627 wrote:

Test Next13360 in Excel2010:

  1. Filled background color blue or light blue.
    NVDA got the same result "aqua-blue".
  2. Filled background color red or dark red.
    NVDA got the same result "red".
    Also, if the fill-backgroundColor name would match with the formatting
    info?
    E.G: fill backgroundColor purple
    formatting info: blue-purple


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#6029 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANf5ne-yuQtsYf0ij6fP8QDetf6qQgtmks5qMMCKgaJpZM4IsTFs.

Michael Curran
Executive Director, NV Access Limited
Phone: +61 7 3149 3306
Website: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented Jun 16, 2016

Technical:

  • NVDA classes a color as pale if it has a saturation of 50% or lower.
    We should change this to 60% or lower.
  • We may want to add a second pale ratio (probably 30%) at which we
    combine the color with the word white, grey or black E.g. blue-grey.
  • Colors with an HSV value (brightness) of 50% or below are classed by
    NVDA as dark. We should add an extra rule so that NVDA classes a color
    as "bright" if its above 75%. Anything between 75% and 50% are just normal.
  • Bright pale should be replaced with light.

On 16/06/2016 1:18 PM, surfer0627 wrote:

Test Next13360 in Excel2010:

  1. Filled background color blue or light blue.
    NVDA got the same result "aqua-blue".
  2. Filled background color red or dark red.
    NVDA got the same result "red".
    Also, if the fill-backgroundColor name would match with the formatting
    info?
    E.G: fill backgroundColor purple
    formatting info: blue-purple


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#6029 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANf5ne-yuQtsYf0ij6fP8QDetf6qQgtmks5qMMCKgaJpZM4IsTFs.

Michael Curran
Executive Director, NV Access Limited
Phone: +61 7 3149 3306
Website: http://www.nvaccess.org/
Twitter: @nvaccess
Facebook: http://www.facebook.com/NVAccess

@nvaccessAuto
Copy link

@nvaccessAuto nvaccessAuto commented Jun 19, 2016

Incubated in 6cd0eba.

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Jul 6, 2016

Test Next13365 in Excel2010:

  1. Filled background color red.
    NVDA report: bright red
  2. Filled background color dark red.
    NVDA report: red
  3. Filled background color light blue.
    NVDA report: bright aqua-blue
  4. Filled background color light green.
    NVDA report: pale yellow-green
    Here, NVDA report two terms "bright" / "pale" for light colors.
    Notes from colors.py:

bright color (HSV saturation 100% and value 100%)
dark color (HSV saturation 100% and value 44%)
pale color (HSV saturation 50% and value 72%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants