/nvda

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFrame vs Frame #6047

Closed
fisher729 opened this Issue Jun 7, 2016 · 4 comments

Comments

Assignees

@feerrenrut feerrenrut

Labels
p2
Projects
None yet
Milestone
  2016.4
6 participants
@fisher729 @PratikP1 @jcsteh @JamaicanUser @nvaccessAuto @feerrenrut
@fisher729

fisher729 commented Jun 7, 2016

NVDA announces frame in Internet Explorer, but IFrame in Mozilla Firefox. Is this an error on NVDAs part? Can the two be aligned to say the same thing when frames are encountered?
@PratikP1

This comment has been minimized.

Show comment
Hide comment
@PratikP1

PratikP1 Jun 7, 2016

Can you please provide example page/pages?

PratikP1 commented Jun 7, 2016

Can you please provide example page/pages?
@fisher729

This comment has been minimized.

Show comment
Hide comment
@fisher729

fisher729 Jun 7, 2016

A good example is on
http://www.freedomscientific.com/Training/Surfs-Up/Frame-Example.htm
Try it in multiple browsers and see the difference.

On 6/7/16, PratikP1 notifications@github.com wrote:

Can you please provide example page/pages?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#6047 (comment)

fisher729 commented Jun 7, 2016

A good example is on
http://www.freedomscientific.com/Training/Surfs-Up/Frame-Example.htm
Try it in multiple browsers and see the difference.

On 6/7/16, PratikP1 notifications@github.com wrote:

Can you please provide example page/pages?

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#6047 (comment)

@nvaccessAuto nvaccessAuto added the p2 label Jul 5, 2016

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Aug 16, 2016

Contributor

Here's what needs to be done here:

  1. Change the role for frames in IE to ROLE_INTERNALFRAME.
  2. Change the label for ROLE_INTERNALFRAME to "frame", since "IFrame" probably doesn't make a huge amount of sense to users.
Contributor

jcsteh commented Aug 16, 2016

Here's what needs to be done here:

  1. Change the role for frames in IE to ROLE_INTERNALFRAME.
  2. Change the label for ROLE_INTERNALFRAME to "frame", since "IFrame" probably doesn't make a huge amount of sense to users.

feerrenrut added a commit that referenced this issue Oct 14, 2016

@feerrenrut
Iframes now reported as frame 
Fixes #6047
In IE IFrames were being reported as "frame" and in Chrome as "IFrame".
Since "frame" is a more user friendly name, now both browsers report as
"frame".
c1700d5

@feerrenrut feerrenrut referenced this issue Oct 14, 2016

Merged

Iframes now reported as frame #6465

@feerrenrut feerrenrut self-assigned this Oct 14, 2016

feerrenrut added a commit that referenced this issue Oct 24, 2016

@feerrenrut
incubates #6465 
Fixes issue #6047
Merge branch 'i6047-IFrameVsFrame' into next
964c2aa

@feerrenrut feerrenrut closed this in #6465 Nov 9, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Nov 9, 2016

feerrenrut added a commit that referenced this issue Nov 9, 2016

@feerrenrut
Iframes now reported as frame (PR #6465) 
Fixes #6047

In IE IFrames were being reported as "frame" and in Firefox as "IFrame".
Since "frame" is a more user friendly name, now both browsers report as
"frame".
4366250

feerrenrut added a commit that referenced this issue Nov 9, 2016

@feerrenrut
Update changes file for PR #6465 
The way IFrames are reported has been made more consistent accross browsers. IFrames are now reported as "frame" in Firefox. (Issue #6047)
e944b4e
@JamaicanUser

This comment has been minimized.

Show comment
Hide comment
@JamaicanUser

JamaicanUser Dec 2, 2016

Oops. There is a spelling error in the English documentation. Across only has one 'c'.

JamaicanUser commented Dec 2, 2016

Oops. There is a spelling error in the English documentation. Across only has one 'c'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment