Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom emulated system keyboard keys #6060

Closed
LeonarddeR opened this issue Jun 9, 2016 · 8 comments · Fixed by #11402
Closed

Custom emulated system keyboard keys #6060

LeonarddeR opened this issue Jun 9, 2016 · 8 comments · Fixed by #11402
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Milestone

Comments

@LeonarddeR
Copy link
Collaborator

Several braille display drivers add emulated system keyboard keys to NVDA, such as escape or alt. It might be an interesting feature if one could add other keys for emulation, for example when one wants to add an emulated system keyboard key to a braille function key which they can't choose by default.
I'd suggest adding a separate button to the imput gestures dialog "Add emulated system keyboard key", which allows you to press a random key on the keyboard which is than added to the emulated system keyboard keys category in the dialog. After that, one should be able to add a gesture to it.

@nvaccessAuto nvaccessAuto added the p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority label Jul 5, 2016
@jcsteh
Copy link
Contributor

jcsteh commented Jul 3, 2017

I'm bothered by having a special button to add emulated keys which is always present. It just doesn't really "fit" and is only relevant to one category. I suggested in #5959 (comment) that we could abuse the Add button to do this only while focused in the emulated keys category. From a technical standpoint, this seems a bit strange, but I think it makes sense from a UX perspective.

@LeonarddeR
Copy link
Collaborator Author

LeonarddeR commented Jul 3, 2017 via email

@LeonarddeR
Copy link
Collaborator Author

I will take this as soon as I have the time for it, but it will probably be a private project, so not on behalf of @BabbageCom. I consider it a relevant issue though, not only specifically for braille.

I will do a self-assignment, but if anyone wants to take this before I start working on it, feel free to poke me.

@dkager
Copy link
Collaborator

dkager commented Dec 3, 2017

I think we should also evaluate the list that is already there. For example:

  • Alt is represented, but not Control.
  • Windows+D is represented, but not the equally useful Windows+B (and others).
  • The super handy applications key or Shift+F10 is missing.
  • Is there a need to translate between the key and its function? I.e. instead of Windows+D, the entry would read "Go to desktop".

@jcsteh
Copy link
Contributor

jcsteh commented Dec 3, 2017

@dkager commented on Dec 3, 2017, 9:08 PM GMT+10:

I think we should also evaluate the list that is already there.

The "list that is already there" is purely based on what braille display driver you have loaded. There is no default list otherwise.

  • Is there a need to translate between the key and its function? I.e. instead of Windows+D, the entry would read "Go to desktop".

I think this is more trouble than its worth. That would require special casing and hard-coding these names.

@dkager
Copy link
Collaborator

dkager commented Dec 9, 2017

The "list that is already there" is purely based on what braille display driver you have loaded. There is no default list otherwise.

Interesting. I would expect there to be a default set, since you might want to assign a specific key to a touch or keyboard gesture.

@LeonarddeR
Copy link
Collaborator Author

@dkager, there will be a default list of toggle scripts as part of #7843.

@LeonarddeR
Copy link
Collaborator Author

I currently have neither time nor interest to work on #7784 any time soon.

@LeonarddeR LeonarddeR removed their assignment Oct 3, 2019
feerrenrut added a commit that referenced this issue Aug 6, 2020
Supersedes PR #7784
Closes #6060.

Co-authored-by: Leonard de Ruijter <leonard@babbage.com>
@nvaccessAuto nvaccessAuto added this to the 2020.3 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
4 participants