New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In excel, a certain document causes freezes #6216

Closed
derekriemer opened this Issue Jul 28, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@derekriemer
Collaborator

derekriemer commented Jul 28, 2016

I will send the document to @michaelDCurran Privately.

  1. Open the excel document.
  2. Navigate down to row 9. Other rows in the 40's freeze NVDA as well.
  3. Expected behavior: Contents are read.
    Behavior: NVDA freezes.
    This is being sent privately because I don't want the document in the public since I didn't create it, and can't figure out how to reproduce.

@feerrenrut feerrenrut added the p1 label Oct 28, 2016

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Oct 28, 2016

Contributor

P1 to investigate the severity of this, and see if we can reproduce.

Contributor

feerrenrut commented Oct 28, 2016

P1 to investigate the severity of this, and see if we can reproduce.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Oct 28, 2016

Collaborator

@feerrenrut do you want me to send the document again? @michaelDCurran has it somewhere but I can send again if needed.

Collaborator

derekriemer commented Oct 28, 2016

@feerrenrut do you want me to send the document again? @michaelDCurran has it somewhere but I can send again if needed.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Oct 31, 2016

Contributor

I still have the file - am looking into this.

Contributor

michaelDCurran commented Oct 31, 2016

I still have the file - am looking into this.

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Oct 31, 2016

Contributor

The freeze in NVDA is due to all 16384 columns in that particular row being merged. NVDA currently has to collect all the column widths of merged cells to work out if the text goes outside the cell (overflow/crop).
However, we can improve this in two ways:

  1. rather than accumulating column widths, just get the last column's left+width.
  2. We can actually remove all the gdi code by simply comparing width-columnWidth. If it is greater than 0, then the cell is overflowed/cropped.
Contributor

michaelDCurran commented Oct 31, 2016

The freeze in NVDA is due to all 16384 columns in that particular row being merged. NVDA currently has to collect all the column widths of merged cells to work out if the text goes outside the cell (overflow/crop).
However, we can improve this in two ways:

  1. rather than accumulating column widths, just get the last column's left+width.
  2. We can actually remove all the gdi code by simply comparing width-columnWidth. If it is greater than 0, then the cell is overflowed/cropped.
@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Oct 31, 2016

Contributor

No, scrap number 2. width always seems to be at least 48.0 no matter how much text is there.

Contributor

michaelDCurran commented Oct 31, 2016

No, scrap number 2. width always seems to be at least 48.0 no matter how much text is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment