New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language handler: Aragonese (an) reported as "unknown language" or "Afar" #6259

Closed
josephsl opened this Issue Aug 11, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@josephsl
Collaborator

josephsl commented Aug 11, 2016

Hi,
Someone contacted me via Skype to report to following:
When you arrow through list of languages in NVDA, Aragonese is listed as either "unknown language" or "Afar".

STR:

  1. Using latest master snapshot, open General Settings and arrow through list of languages.
  2. Locate Aragonese (or attempt to locate it).

Expected: Aragonese is listed.
Actual: either "unknown language" or "Afar" is shown in place of Aragonese (an).

Thanks.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 11, 2016

Collaborator

Hi,

Technical: I don't know why, but Windows returns lang code 4096 for all unknown langs. I'm afraid a case to catch this is in order (unless 4096 is used for specific LCID).

If this is a major showstopper, I'd be happy to create a PR; on the other hand, I'd like to recommend a new developer (perhaps someone outside of NV Access) should do it so they can learn something new.

Thanks.

Collaborator

josephsl commented Aug 11, 2016

Hi,

Technical: I don't know why, but Windows returns lang code 4096 for all unknown langs. I'm afraid a case to catch this is in order (unless 4096 is used for specific LCID).

If this is a major showstopper, I'd be happy to create a PR; on the other hand, I'd like to recommend a new developer (perhaps someone outside of NV Access) should do it so they can learn something new.

Thanks.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Aug 11, 2016

Collaborator

Hi,

Reference:

No wonder why Windows 10 systems show "unknown language"...

Thanks.

Collaborator

josephsl commented Aug 11, 2016

Hi,

Reference:

No wonder why Windows 10 systems show "unknown language"...

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Aug 12, 2016

Language handler: Aragonese is no longer displayed as 'unknown langua…
…ge'. re #6259

According to MSDN, LCID 0x1000 (4096) is treated as a custom locale by users. This affected how Aragonese entry is presented in General Settings/language combo box (in Windows 10, it shows up as 'unknown language'). Thus take care of this case.
Also took this time to add needed copyright headers (based on git log archive).

josephsl added a commit to josephsl/nvda that referenced this issue Sep 22, 2016

Use hex (0x1000). re #6259
Reviewed by Jamie Teh (NV Access): use hex for clarity.

jcsteh added a commit that referenced this issue Sep 22, 2016

@jcsteh jcsteh closed this in #6261 Oct 18, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 18, 2016

jcsteh added a commit that referenced this issue Oct 18, 2016

In the list of languages in NVDA's General Settings dialog, languages…
… such as Aragonese are now displayed correctly on Windows 10. (#6259)

According to MSDN, LCID 0x1000 (4096) is treated as a custom locale by users. This affected how Aragonese entry is presented in General Settings/language combo box (in Windows 10, it shows up as 'unknown language'). Thus take care of this case.
Also took this time to add needed copyright headers (based on git log archive).
PR #6261.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment