Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelling while opening a new document before it has started loading leaves user with no buffer #63

Closed
nvaccessAuto opened this Issue Jan 1, 2010 · 3 comments

Comments

Projects
None yet
1 participant
@nvaccessAuto
Copy link

nvaccessAuto commented Jan 1, 2010

Reported by jteh on 2008-04-09 10:07
If a user opens a new document but cancels the request before the new document has actually started loading (i.e. the old document is still on screen), the user will be left with no virtual buffer.

Steps to Reproduce

  1. Load any page, as long as it's fully loaded and has a proper buffer.
  2. Go to an address that will take a while to load. The best way to do this is to use an address that will time out; e.g. http://11.22.33.44/ . :) This causes the document to go busy.
  3. Now press escape.

Actual Results

After pressing escape, there is no longer an active virtual buffer. In technical terms, there's no way to get our buffer back because we killed it off when it went busy. Alt+tabbing fixes it. For some reason, simply tabbing does not.

Expected Results

The user should be returned to the buffer as it was prior to attempting to open the new document.

Additional Comments

I'm not sure how to solve this one. Even if we do get a state change back to read only and not busy (I would hope we do), there's no way to get it because we've killed our buffer object.

This all makes me wonder about the idea of not checking the busy state; i.e. the document gets loaded on focus and doc load complete, but busy isn't a requirement.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jan 1, 2010

Comment 1 by jteh on 2008-05-30 01:35
A solution might be to not kill the buffer if its document's state changes to busy. However, we would still not create a buffer if the document is busy.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jan 1, 2010

Comment 2 by mdcurran on 2008-06-12 05:51
Fixed in r2120. Could have some side affects. isAlive doesn't care about state_busy anymore.

@nvaccessAuto

This comment has been minimized.

Copy link
Author

nvaccessAuto commented Jan 1, 2010

Comment 3 by jteh on 2008-06-16 02:37
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2009.1 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.