New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use description for Mozilla dialogs instead of our own getDialogText code #630

Closed
nvaccessAuto opened this Issue Apr 21, 2010 · 5 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented Apr 21, 2010

Reported by jteh on 2010-04-21 07:56
If aria-describedby is set on an ARIA dialog, Mozilla will expose this as the description. We should use this in preference to our own getDialogText code.

Test cases: tests 2 and 3 at http://www.accessibleculture.org/testing/aria/alertdialog/

Considerations:

  • Do we somehow stop our Dialog behavior from being used or do we tweak the Dialog behavior to not bother with getDialogText if description is valid?
  • Are there any cases where other dialogs provide a useless description? If so, we don't want to do this for all dialogs, only Mozilla ones.
@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 21, 2010

Comment 1 by jteh on 2010-04-21 08:03
Actually, probably a bug; we really should use information that is given to us for free. :)

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Apr 22, 2010

Comment 2 by jteh on 2010-04-22 05:26
Implemented in 3056065.

We were unable to find any dialogs that expose a pointless description. If some are found, we will need to special case them or reconsider this fix.
Changes:
State: closed

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 20, 2010

Comment 3 by hhillen on 2010-05-20 14:23
It seems this issue is still occurring or occurring again in Firefox 3.7. For the provided test cases the dialog descriptions are no longer announced by NVDA, even though they are exposed in MSAA
Changes:
State: reopened

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 20, 2010

Comment 4 by jteh on 2010-05-20 21:41
Broken support in Firefox 3.7 is known and is because of MozillaBug:539252. See also MozillaBug:561924. Unfortunately, I suspect that NVDA will break with some version of Firefox no matter what we do.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented Jul 28, 2010

Comment 6 by jteh on 2010-07-28 06:02
Fixed in 60c9860 without breaking Firefox 3.6. Yay!
Changes:
State: closed

@nvaccessAuto nvaccessAuto added the bug label Nov 10, 2015

@nvaccessAuto nvaccessAuto added this to the 2010.2 milestone Nov 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment