Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing between labels and combo boxes #6342

Closed
feerrenrut opened this issue Sep 6, 2016 · 0 comments
Closed

Spacing between labels and combo boxes #6342

feerrenrut opened this issue Sep 6, 2016 · 0 comments
Labels
component/NVDA-GUI
Milestone
2016.4

Comments

@feerrenrut
Copy link
Contributor

Feedback on GUI, received via email.

there is no real spacing between the labels and the combo boxes. This means the end of the label is touching the left edge of the combo box. This is not aesthetically how options in dialogs look. It makes the UI look messy because the text appears to run into the combo box

This applies to the language option and the logging level option on the general settings dialog, but may well apply to all other dialogs in NVDA. We need to decide on a spacing here (e.g. 5 px) and use it consistently to separate text from the left sides of combos.

Note that there is no problem with the spacing between check boxes and their labels that are to the right of the check boxes. This seems to be only a problem for combo boxes and maybe other text fields etc. I will look at other dialogs and comment where appropriate.
@feerrenrut feerrenrut mentioned this issue Sep 6, 2016
Closed
feerrenrut added a commit that referenced this issue Sep 29, 2016
@feerrenrut
incubates #6287
484cdc0 
For issues:
 #6317 (Gestures treeview does not look like a treeview)
 #5548 (Text control to specify the path when creating a portable copy is
quite narrow)
 #6342 (Spacing between labels and combo boxes)
 #6343 (Inconsistency with vertical spacing between checkbox/label
options)
 #6349 (input gestures dialog tree view too small)

Merge branch 'fixGuiAlignmentIssues' into next

Conflicts:
	source/gui/settingsDialogs.py
          - voice settings (speak numbers as)
          - SpeechSymbolsDialog (mouse interaction)
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 13, 2016
feerrenrut added a commit that referenced this issue Oct 13, 2016
@feerrenrut
Update changes file for PR #6287, #6402, #6339
1884c56 
For PR #6287 - Various padding and alignment issues have been resolved. (#6317, #5548, #6342, #6343, #6349)
For PR #6402 - The document formatting dialog has been adjusted so that the contents scrolls. (#6348)
For PR #6339 - Adjusted the layout of the symbols pronunciation dialog so the full width of the dialog is used for the symbols list. (#6101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/NVDA-GUI
Projects
None yet
Milestone
2016.4
Development

No branches or pull requests
2 participants
@feerrenrut @nvaccessAuto