Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech dictionary allows blank pattern (causes replacement to be read constantly) #6412

Closed
Qchristensen opened this issue Sep 29, 2016 · 4 comments
Assignees
Labels
p1
Milestone

Comments

@Qchristensen
Copy link
Contributor

@Qchristensen Qchristensen commented Sep 29, 2016

To replicate:

  • Add a dictionary entry
  • Leave the pattern field blank
  • Add any text into the Replacement field.
  • OK the new entry and the dictionary dialogs.

Recommended solution: Don't allow entry to be OK'd while pattern is blank and replacement is not.

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Sep 29, 2016

Just to clarify, we do need to allow blank replacements though.

On 9/28/2016 11:52 PM, Quentin Christensen wrote:

To replicate:

  • Add a dictionary entry
  • Leave the pattern field blank
  • Add any text into the Replacement field.
  • OK the new entry and the dictionary dialogs.

Recommended solution: Don't allow entry to be OK'd while pattern is
blank and replacement is not.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#6412, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivdg7kfIrYLvoou3WuLJSPNldQHAYks5qu1ItgaJpZM4KJmu8.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

@Qchristensen
Copy link
Contributor Author

@Qchristensen Qchristensen commented Sep 29, 2016

Sure, the problem here is definitely if you have no text in the pattern field but text in the replace field, it will add the replace text to everything NVDA says - I can't come up with any scenario where that would be useful?

Possibly could also not save entries which have both fields blank? That doesn't cause anything extra to be said, not sure if there's any kind of (probably minor?) performance impact by it adding to everything that is uttered?

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Sep 29, 2016

Yeah, this is for sore a problem.

On 9/28/2016 11:58 PM, Quentin Christensen wrote:

Sure, the problem here is definitely if you have no text in the
pattern field but text in the replace field, it will add the replace
text to everything NVDA says - I can't come up with any scenario where
that would be useful?

Possibly could also not save entries which have both fields blank?
That doesn't cause anything extra to be said, not sure if there's any
kind of (probably minor?) performance impact by it adding to
everything that is uttered?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#6412 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFGivSTfhTvmRCijT7e9fp6EK_EEoME6ks5qu1OOgaJpZM4KJmu8.


Derek Riemer
  • Department of computer science, third year undergraduate student.
  • Proud user of the NVDA screen reader.
  • Open source enthusiast.
  • Member of Bridge Cu
  • Avid skiier.

Websites:
Honors portfolio http://derekriemer.com
Awesome little hand built weather app!
http://django.derekriemer.com/weather/

email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu
Phone: (303) 906-2194

@jcsteh jcsteh added the p1 label Oct 7, 2016
@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Oct 7, 2016

P1 because this is quite problematic for users if they accidentally do it.

feerrenrut added a commit that referenced this issue Oct 12, 2016
A blank pattern in a dictionary entry causes issues see, #6412
feerrenrut added a commit that referenced this issue Oct 13, 2016
Fixes issue #6412
Merge branch 'i6412-EmptyPatternInDictionaryEntry' into next
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Oct 27, 2016
feerrenrut added a commit that referenced this issue Oct 27, 2016
The "pattern" field for a new dictionary entry is no longer allowed to be left blank. (Issue: #6412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants