New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate displayModel branch in to NVDA #643

Closed
nvaccessAuto opened this Issue May 10, 2010 · 6 comments

Comments

Projects
None yet
2 participants
@nvaccessAuto

nvaccessAuto commented May 10, 2010

Reported by mdcurran on 2010-05-10 07:05
After the displayModel branch of NVDA is stable enough it should be merged in to main. As many other tickets rely on this happening, this ticket can act as a meta ticket so that we can keep track of all the other ones. Then we can reassess all ot them once this ticket has been closed.

Blocking #58, #151, #200, #582, #605

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 10, 2010

Comment by mdcurran on 2010-05-10 07:15
(In #151) All should be solved by using displayModel.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 10, 2010

Comment by mdcurran on 2010-05-10 07:35
(In #200) Implemented in displayModel,3464.1.10
Once displayModel branch is merged this can be closed.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 10, 2010

Comment by mdcurran on 2010-05-10 07:37
(In #605) Works great with displayModel branch. Once merged this ticket can be closed.

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 10, 2010

Comment 5 by jteh on 2010-05-10 10:32
I'm confused about the relationship between this ticket and #40...

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 10, 2010

Comment 6 by mdcurran on 2010-05-10 10:54
Slightly my mystake -- I didn't realize (or I forgot) that ticket 40 had quite a few comments related to the new display model -- I only thought it really contained my first new code intro comment.
I also didn't realize that all those display related tickets were already blocking 40. I'll learn to check next time :)
However, I think I'd prefer to keep it this way for now anyway as really the task is to merge displayModel, and all those tickets can automatically be closed once that happens, we're not really talking about major new features having to be implemented now.
But yeah, I could have saved myself the trouble if I'd looked :)

@nvaccessAuto

This comment has been minimized.

nvaccessAuto commented May 13, 2010

Comment 8 by jteh on 2010-05-13 04:03
Done in c90061b.
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment