Tables ignore the numbers in word #6446

Closed
derekriemer opened this Issue Oct 11, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@derekriemer
Collaborator

derekriemer commented Oct 11, 2016

In this preview table, alt+ctrl+down in col 1 doesn't read the numbers.
Match the mountain range with the continent.docx
Match the mountain range with the continent.docx
change txt to docx

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Oct 11, 2016

Collaborator

This is a fake test question which resembles the bug presented by a real test question in a bio psych class, of which I can't publish because I don't have the test it was part of any more, and it's against the professors policy for me to do so.

Collaborator

derekriemer commented Oct 11, 2016

This is a fake test question which resembles the bug presented by a real test question in a bio psych class, of which I can't publish because I don't have the test it was part of any more, and it's against the professors policy for me to do so.

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Oct 12, 2016

Contributor

I can reproduce this with NVDA Version: next-13613,c68a4d43 on windows 10 and with MS word 2013.

The document contains a table with two columns. Each column contains a numbered list, with one item per row. The first column has items with 1. 2. 3 the second with A. B. C.

None of the numbers/letters are read out when moving through the cells.

Contributor

feerrenrut commented Oct 12, 2016

I can reproduce this with NVDA Version: next-13613,c68a4d43 on windows 10 and with MS word 2013.

The document contains a table with two columns. Each column contains a numbered list, with one item per row. The first column has items with 1. 2. 3 the second with A. B. C.

None of the numbers/letters are read out when moving through the cells.

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Oct 12, 2016

Contributor

There is a work around, by using the read current line command while in each cell. This will successfully read the whole cell but not the whole row.

Contributor

feerrenrut commented Oct 12, 2016

There is a work around, by using the read current line command while in each cell. This will successfully read the whole cell but not the whole row.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Oct 12, 2016

Contributor

Technical: This occurs because list numbering uses the line-prefix attribute, but this is only read for UNIT_LINE and UNIT_PARAGRAPH. Word table movement doesn't currently pass a unit. I think we can pass UNIT_PARAGRAPH. Passing UNIT_PARAGRAPH to speakTextInfo in NVDAObjects.window.winword._moveInTable does seem to fix this, but we need to check that there aren't negative implications.

Contributor

jcsteh commented Oct 12, 2016

Technical: This occurs because list numbering uses the line-prefix attribute, but this is only read for UNIT_LINE and UNIT_PARAGRAPH. Word table movement doesn't currently pass a unit. I think we can pass UNIT_PARAGRAPH. Passing UNIT_PARAGRAPH to speakTextInfo in NVDAObjects.window.winword._moveInTable does seem to fix this, but we need to check that there aren't negative implications.

@jcsteh jcsteh added the p2 label Oct 12, 2016

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Oct 12, 2016

Contributor

P2 because this causes users to miss information and the fix should be fairly trivial.

Contributor

jcsteh commented Oct 12, 2016

P2 because this causes users to miss information and the fix should be fairly trivial.

@derekriemer

This comment has been minimized.

Show comment
Hide comment
@derekriemer

derekriemer Oct 12, 2016

Collaborator

Correct, however while arrowing through a document they work perfectly fine.

Sent from a mobile device.
Please disregard errors as this is a smaller device.

On Oct 11, 2016, at 21:14, Reef Turner notifications@github.com wrote:

I can reproduce this with NVDA Version: next-13613,c68a4d43 on windows 10 and with MS word 2013.

The document contains a table with two columns. Each column contains a numbered list, with one item per row. The first column has items with 1. 2. 3 the second with A. B. C.

None of the numbers/letters are read out when moving through the cells.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Collaborator

derekriemer commented Oct 12, 2016

Correct, however while arrowing through a document they work perfectly fine.

Sent from a mobile device.
Please disregard errors as this is a smaller device.

On Oct 11, 2016, at 21:14, Reef Turner notifications@github.com wrote:

I can reproduce this with NVDA Version: next-13613,c68a4d43 on windows 10 and with MS word 2013.

The document contains a table with two columns. Each column contains a numbered list, with one item per row. The first column has items with 1. 2. 3 the second with A. B. C.

None of the numbers/letters are read out when moving through the cells.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@feerrenrut feerrenrut self-assigned this Oct 14, 2016

feerrenrut added a commit that referenced this issue Oct 14, 2016

Use paragraph as unit when reading in table
When moving in a table, use a paragraph unit when reading text to ensure
that the number for a numbered list item in the cell is read.

Fixes #6446.

feerrenrut added a commit that referenced this issue Oct 24, 2016

incubates #6464
Fix for issue #6446
Merge branch 'i6446-numbersInTablesIgnored' into next

@feerrenrut feerrenrut closed this in #6464 Nov 9, 2016

@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Nov 9, 2016

feerrenrut added a commit that referenced this issue Nov 9, 2016

Use paragraph as unit when reading in table (PR #6464)
When moving in a table, use a paragraph unit when reading text to ensure
that the number for a numbered list item in the cell is read.

Fixes #6446.

feerrenrut added a commit that referenced this issue Nov 9, 2016

Update changes file for PR #6464
Numbered bullets are now read from table cells in Microsoft Word when moving by cell. (Issue #6446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment