New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference between report current line and review current line with automatic language switching checked #6726

Closed
tspivey opened this Issue Jan 13, 2017 · 2 comments

Comments

Projects
None yet
4 participants
@tspivey
Contributor

tspivey commented Jan 13, 2017

STR:

  1. Open test.html in Firefox.
  2. Switch to English eSpeak, with Automatic language switching checked.
  3. Press report current line twice. I hear letters spoken in English.
  4. Press review current line twice. I hear letters spoken in Esperanto.

Expected:
Both of these should speak Esperanto letters, since I'm reading the same text.
test.txt

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jan 13, 2017

Contributor

Confirmed. Occurs because script_reportCurrentLine calls speakSpelling with info.text instead of spellTextInfo. (The review script does call spellTextInfo.) I'm guessing this was just an oversight in 55b779e. @michaelDCurran, can you think of any reason we wouldn't have changed reportCurrentLine other than oversight?

P2 because while it's probably not a common use case and there's a simple workaround, it should be trivial to fix. Reassess priority if fix turns out not to be trivial.

Contributor

jcsteh commented Jan 13, 2017

Confirmed. Occurs because script_reportCurrentLine calls speakSpelling with info.text instead of spellTextInfo. (The review script does call spellTextInfo.) I'm guessing this was just an oversight in 55b779e. @michaelDCurran, can you think of any reason we wouldn't have changed reportCurrentLine other than oversight?

P2 because while it's probably not a common use case and there's a simple workaround, it should be trivial to fix. Reassess priority if fix turns out not to be trivial.

@jcsteh jcsteh added the p2 label Jan 13, 2017

@michaelDCurran

This comment has been minimized.

Show comment
Hide comment
@michaelDCurran

michaelDCurran Jan 13, 2017

Contributor
Contributor

michaelDCurran commented Jan 13, 2017

tspivey added a commit to tspivey/nvda that referenced this issue Feb 17, 2017

@jcsteh jcsteh closed this in #6894 Apr 5, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Apr 5, 2017

jcsteh added a commit that referenced this issue Apr 5, 2017

Fixes to reportCurrentLine's spelling functionality (#6894)
- Performing the read current line command three times quickly spells the line with character descriptions. (#6893) 
- When performing the read current line command twice quickly to spell the line, the appropriate language is now used for the spelled characters. (#6726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment