Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Volume Synth Settings Ring increment/decrement to 5 #6754

Closed
bhavyashah opened this issue Jan 18, 2017 · 9 comments
Closed

Reduce Volume Synth Settings Ring increment/decrement to 5 #6754

bhavyashah opened this issue Jan 18, 2017 · 9 comments

Comments

@bhavyashah
Copy link

@bhavyashah bhavyashah commented Jan 18, 2017

Currently, upon navigating to Volume in the Synth Settings Ring and increasing/decreasing the volume, the change value is 10. However, while using headphones and often even on speakers, amounts of 10 bring about significant differences. Particularly when using NVDA at low volumes, one may wish to change volume by an amount of much lesser than 10, which cannot be achieved seamlessly using the Synth Settings Ring and necessitates usage of the Voice Settings dialog.
As a solution to the above problem I periodically encounter, I propose changing the increment/decrement amount of the Volume option in the Synth Settings Ring to 5 instead of 10, alike the Rate option. This will enable greater flexibility on the fly.

@PratikP1
Copy link

@PratikP1 PratikP1 commented Jan 18, 2017

Loading

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jan 18, 2017

Hi,

Are there synthesizers that cannot set volume to increments of five percent? If so, we cannot proceed, otherwise a developer working on this should change volume setting in synth driver handler to not use normal step of 10.

CC @tspivey, @ragb

Thanks.

Loading

@bhavyashah
Copy link
Author

@bhavyashah bhavyashah commented Aug 19, 2018

@tspivey @ragb Could you please respond to @josephsl's #6754 (comment)?

Loading

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Sep 16, 2018

This should be fine to perform

Loading

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Sep 16, 2018

Hi,

Because this change may break some synthesizers that cannot handle this change, we should publish a note about this once a PR for this one is merged.

Thanks.

Loading

@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Apr 9, 2019

Because this change may break some synthesizers that cannot handle this change, we should publish a note about this once a PR for this one is merged

@josephsl Do you know of any examples?

Loading

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Apr 9, 2019

Loading

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Apr 9, 2019

I cannot think of a synthesizer which would not support this feature. But the best way is to maybe release a try build with this feature implemented and ask for user reports.

Loading

@nvaccessAuto nvaccessAuto added this to the 2019.2 milestone Apr 10, 2019
feerrenrut added a commit that referenced this issue Apr 10, 2019
Fixes #6754.

Summary of the issue:
When changing synth volume setting using the settings ring, the value is increased and decreased by 10, which is too much for some users.

Description of how this pull request fixes the issue:
As suggested in #6754, the step has been decreased to 5, which is more acceptable.
feerrenrut added a commit that referenced this issue Apr 10, 2019
Synthesizer volume is now increased and decreased by 5 instead of 10 when using the settings ring. (Issue #6754)
@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Apr 10, 2019

But the best way is to maybe release a try build with this feature implemented and ask for user reports.

I'm happy with this plan, I have merged it. Please contact me if there are issues with synths.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants