Cannot "escape" out of the "Confirm Deletion" prompt when the Deleting Configuration button is pressed #6851

Closed
Qchristensen opened this Issue Feb 8, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@Qchristensen

In NVDA's Configuration profiles dialog, select a profile, and press alt+d or activate the "delete" button.

The "Confirm deletion" prompt appears. Options are Yes or No.

Pressing escape should select no and close the dialog without deleting, however it does nothing. There is no need for a "cancel" button as "No" performs the same function.

Not high priority, however potentially opens up possibility of inadvertently deleting a configuration profile if someone accidentally opens the delete prompt and thinks they have dismissed it with escape.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Feb 8, 2017

Collaborator

Hi,

Confirmed.

Technical: gui.messageBox flags might be the culprit here.

Thanks.

Collaborator

josephsl commented Feb 8, 2017

Hi,

Confirmed.

Technical: gui.messageBox flags might be the culprit here.

Thanks.

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Feb 13, 2017

Contributor

Looks like this is because we are using wx.YES | wx.NO flags with the message box.
The wx docs for messageBox specifies:

It is recommended to always use wxCANCEL with this style as otherwise the message box won't have a close button under wxMSW and the user will be forced to answer it.

Adding wx.CANCEL allows the dialog to be dismissed with the esc key

Contributor

feerrenrut commented Feb 13, 2017

Looks like this is because we are using wx.YES | wx.NO flags with the message box.
The wx docs for messageBox specifies:

It is recommended to always use wxCANCEL with this style as otherwise the message box won't have a close button under wxMSW and the user will be forced to answer it.

Adding wx.CANCEL allows the dialog to be dismissed with the esc key

@Qchristensen

This comment has been minimized.

Show comment
Hide comment
@Qchristensen

Qchristensen Feb 13, 2017

@feerrenrut

This comment has been minimized.

Show comment
Hide comment
@feerrenrut

feerrenrut Feb 13, 2017

Contributor

Adding wx.CANCEL results in three buttons (yes, no, and cancel). Rather than do that I have re-worded the sentence, swapped to use the ok/cancel buttons. The message box will now say:

This profile will be permanently deleted, this action cannot be undone.

Contributor

feerrenrut commented Feb 13, 2017

Adding wx.CANCEL results in three buttons (yes, no, and cancel). Rather than do that I have re-worded the sentence, swapped to use the ok/cancel buttons. The message box will now say:

This profile will be permanently deleted, this action cannot be undone.

@Qchristensen

This comment has been minimized.

Show comment
Hide comment
@Qchristensen

Qchristensen Feb 13, 2017

feerrenrut added a commit that referenced this issue Feb 13, 2017

feerrenrut added a commit that referenced this issue Feb 14, 2017

incubates #6884
for issue #6851
Merge branch 'i6851-escapeFromDeleteConf' into next

@feerrenrut feerrenrut closed this in #6884 Mar 14, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.2 milestone Mar 14, 2017

feerrenrut added a commit that referenced this issue Mar 14, 2017

Change wording of delete profile confirmation (PR #6884)
Pressing `ESC` while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. To do this, the wording was changed, and the `yes/no` buttons were replaced with `ok/cancel` buttons.

Fixes #6851

feerrenrut added a commit that referenced this issue Mar 14, 2017

Update changes file for several PRs
For PR #6761 - Web page menu items (menu item checkbox's and radio buttons) can now be activated while in browse mode.  Issue #6735
For PR #6866 - Excel sheet name reporting is now translated. Issue #6848
For PR #6884 - Pressing ESC while the configuration profile "Confirm Deletion" prompt is active now dismisses the dialog. Issue #6851
For PR #6895 - Cell border information can now be reported in Microsoft Excel by using `NVDA+f`. Issue #3044
For PR #6860 - Added support for aria-current attributes. Issue #6358
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment