Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibreOffice Calc: report selected cell coordinates #6897

Closed
surfer0627 opened this issue Feb 18, 2017 · 13 comments · Fixed by #12849
Closed

LibreOffice Calc: report selected cell coordinates #6897

surfer0627 opened this issue Feb 18, 2017 · 13 comments · Fixed by #12849
Labels
app/libreoffice blocked/needs-external-fix
Milestone
2022.1

Comments

@surfer0627
Copy link
Contributor

@surfer0627 surfer0627 commented Feb 18, 2017

This is a feature request that NVDA report selected cell coordinates.
Steps to reproduce:

  1. Open Calc.
  2. Press shift+downArrow.
    NVDA report: nothing
    expected: a1 through a2 selected
  3. press ctrl+home to move to top.
  4. Press shift+space to select entire row
    NVDA report: space
    expected: a1 through amj1 selected
@zahra21
Copy link

@zahra21 zahra21 commented Jan 16, 2018

hi.
i confirm this issue.
does nvda support reporting of selection in microsoft excel?
if you found solution for this, please inform me.
thanks and God bless all.

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Apr 1, 2019

@zahra21 yes in Excel this is supported. In Libre Calc this is still an issue. Right?

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Aug 8, 2019

It seems that LibreOffice developer Tamás Zolnai committed a patch related to this issue (adding selection-changed event).

bug 93825 – Missing accessibility events when selecting/deselecting cells in Calc

cc @leonardder: Could you please check, if this is helpful?

Thanks.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Aug 8, 2019

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Aug 8, 2019 •
edited

Yes, developer Tamás Zolnai pointed out that it is available in 5.2.4. @leonardder

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Aug 8, 2019

@surfer0627
Copy link
Contributor Author

@surfer0627 surfer0627 commented Aug 8, 2019

In this case, LibreOffice developer said "selection change event is added."
But, this patch does not fix screen reader NVDA "report selected cell coordinates".
What should we do (Let LibreOffice developer know the gap)?
Or how to use this "selection change event to implement feature "report selected cell coordinates?

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Aug 8, 2019

@nktech1135
Copy link

@nktech1135 nktech1135 commented Oct 14, 2020 •
edited

Is anyone working on this? It's still an issue in libreoffice 7.0.2 and nvda 2020.3
A fix would be greatly appreciated.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Oct 14, 2020

Apart from the patch refered to in #6897 (comment), it looks like LibreOffice people aren't that accessibility minded unfortunately.

@nktech1135
Copy link

@nktech1135 nktech1135 commented Oct 14, 2020

it looks like LibreOffice people aren't that accessibility minded unfortunately.

Do we have examples of this? Were the correct bugs ever filed against libreoffice to make them aware of the issue? I'm not a developer so can't file the bugs myself as i wouldn't know what to point at or what the behind the seens tech speak would be.

@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Oct 14, 2020

A number of accessibility bugs filed, many issues here with the app/libreoffice label have links to bugs on the issue tracker for libreoffice.

I have tried to reach out to a few developers who work on libreoffice, for the record NV Access is willing to work with libreoffice developers to help solve these issues. They can contact us via info@nvaccess.org to start a conversation.

@Qchristensen
Copy link
Member

@Qchristensen Qchristensen commented Oct 15, 2020

There is an issue on LibreOfice's bug tracker for this, which goes back to 2016: https://bugs.documentfoundation.org/show_bug.cgi?id=100086 (with references to an older issue again).

@leonardder leonardder mentioned this issue Sep 11, 2021
Closed
michaelweghorn added a commit to michaelweghorn/nvda that referenced this issue Sep 14, 2021
@michaelweghorn
DEMO: soffice: Announce coordinates of selected cells (nvaccess#6897)
31dbfaa 
This is just a demo to show how handling the
different 'event_selection*' events for
SymphonyTable and SymphonyTableCell could in general
be used to announce the current selection of multiple
cells.

It adds a method 'announce_selected_cells' to
SymphonyTable that just announces the names
of the first and last cell in the current selection
for now.

To avoid the same selection being announced multiple
times, the first and last cell of the last time
the method has been called is remembered and the
announcement is only done if the current selection
is different.
(The method may be called multiple times for the same
selection, since e.g. multiple SELECTION_ADD events
are triggerdd when multiple cells are added to a
selection at the same time.)

NOTES:

* This demo requires a current development version of
  LibreOffice to work.

* 'event_selectionRemove' is not triggered as expected,
  so the selection is not announced when removing cells
  from the selection using Shift+arrow keys.
  This looks like a problem on LibreOffice side.

* There are some other cases where events are not
  triggered as expeced on LO side, s.e.g.
  tdf#118508 [1] or tdf#18748 [2], which are
  also LibreOffice problems that need be handled there.

(Note: Strictly speaking, the change to
SymphonyTable::getSelectedItemsCount is unrelated, just makes
use of the newly added implementation of IAccessibleTable2.)

[1] https://bugs.documentfoundation.org/show_bug.cgi?id=118508
[2] https://bugs.documentfoundation.org/show_bug.cgi?id=118748
@leonardder leonardder mentioned this issue Sep 15, 2021
Merged
9 tasks
seanbudd pushed a commit that referenced this issue Oct 20, 2021
@leonardder
Improve selection and merged cell announcements in LibreOffice Calc 7…
32bf54e 
….3 and above (#12849)

Link to issue number:
Fixes #9310
Fixes #6897

Summary of the issue:
In LibreOffice calc, selection is not announced and for merged cells, only the first cell is announced.

Description of how this pull request fixes the issue:
In LibreOffice 7.3 development branch, support for IAccessibleTable2 and IAccessibleTableCell were added. This allows us to implement something that works as expected.
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 20, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.3 milestone Oct 20, 2021
@feerrenrut feerrenrut removed this from the 2021.3 milestone Oct 20, 2021
@feerrenrut feerrenrut added this to the 2022.1 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/libreoffice blocked/needs-external-fix
Projects
None yet
Milestone
2022.1
Development

Successfully merging a pull request may close this issue.

Improve selection and merged cell announcements in LibreOffice Calc 7.3 and above leonardder/nvda
9 participants
@leonardder @feerrenrut @nvaccessAuto @surfer0627 @Qchristensen @nktech1135 @ehollig @zahra21 @Adriani90