New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Liblouis 3.2.0 #6935

Closed
josephsl opened this Issue Mar 6, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@josephsl
Collaborator

josephsl commented Mar 6, 2017

Hi,

Liblouis 3.1.0 has been released. This release includes tons of changes to back-translation submitted by @jcsteh (a great help for #2439), braille table improvements, and couple new tables such as Chinese (simplified) table and enhanced Greek and Turkish tables.

Thanks.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl
Collaborator

josephsl commented Mar 6, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Mar 20, 2017

Contributor

I started an i6935Liblouis3.1 branch which updates the build system with a change necessary to build liblouis 3.1.0. However, liblouis 3.1.0 fails to build as-is with NVDA. I've submitted liblouis/liblouis#300 to fix this. liblouis 3.1.0 is also missing liblouis/liblouis#211 which we need for contracted braille input.

So, I think we're going to need to ship a slightly modified liblouis until these things get incorporated into a liblouis release. Because some of this depends on contracted braille input, I'll probably just handle that in #6449 (unless we really need liblouis 3.1.0 before that ships).

Contributor

jcsteh commented Mar 20, 2017

I started an i6935Liblouis3.1 branch which updates the build system with a change necessary to build liblouis 3.1.0. However, liblouis 3.1.0 fails to build as-is with NVDA. I've submitted liblouis/liblouis#300 to fix this. liblouis 3.1.0 is also missing liblouis/liblouis#211 which we need for contracted braille input.

So, I think we're going to need to ship a slightly modified liblouis until these things get incorporated into a liblouis release. Because some of this depends on contracted braille input, I'll probably just handle that in #6449 (unless we really need liblouis 3.1.0 before that ships).

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Mar 20, 2017

Collaborator

Could you ship a slightly modified liblouis 3.1.0? For the time being I'd like to make an add-on that includes the en-us-comp8-ext table. That would be easier and less hacky if the file is available in louis\tables, which it is as per liblouis 3.1.0.

Collaborator

dkager commented Mar 20, 2017

Could you ship a slightly modified liblouis 3.1.0? For the time being I'd like to make an add-on that includes the en-us-comp8-ext table. That would be easier and less hacky if the file is available in louis\tables, which it is as per liblouis 3.1.0.

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Mar 20, 2017

Contributor

The problem is that this causes some pretty serious conflicts with #6449, which is currently on next. Thus, it's going to be very hard to ensure this gets tested properly. I'm going to try to move #6449 further along so we can hopefully ship it sooner rather than later. If my efforts fail, I'll look at how to solve this in the interim. Thanks for your patience.

Contributor

jcsteh commented Mar 20, 2017

The problem is that this causes some pretty serious conflicts with #6449, which is currently on next. Thus, it's going to be very hard to ensure this gets tested properly. I'm going to try to move #6449 further along so we can hopefully ship it sooner rather than later. If my efforts fail, I'll look at how to solve this in the interim. Thanks for your patience.

@dkager

This comment has been minimized.

Show comment
Hide comment
@dkager

dkager Jun 4, 2017

Collaborator

@josephsl Would you mind updating the title to liblouis 3.2.0, which will be released soon?

In this next release I made a few improvements to the Windows build system with NMake. @jcsteh I hope it plays nicely with NVDA's build magic now.

Collaborator

dkager commented Jun 4, 2017

@josephsl Would you mind updating the title to liblouis 3.2.0, which will be released soon?

In this next release I made a few improvements to the Windows build system with NMake. @jcsteh I hope it plays nicely with NVDA's build magic now.

@jcsteh jcsteh changed the title from Upgrade to Liblouis 3.1.0 to Upgrade to Liblouis 3.2.0 Jun 15, 2017

@jcsteh jcsteh closed this in #6449 Jul 7, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jul 7, 2017

jcsteh added a commit that referenced this issue Jul 7, 2017

Support for uncontracted and contracted braille input. (PR #6449; iss…
…ues #2439, #6054, #6113, #6935)

Beyond the main code in brailleInput to support uncontracted/contracted input, this includes the following changes:
* The list of braille tables has been moved out of the braille module into a separate brailleTables module. Braille tables are now added with a function rather than directly adding them to the data structure. Aside from being necessary in order to specify and check whether a table is contracted, this also makes the data about tables more extensible in future.
* As the data structure for braille tables has now changed and is no longer ordered, this was a good opportunity to sort the list of tables alphabetically when displaying them to the user.
* Updated to liblouis master shortly after release 3.2.0. The post 3.2.0 commits include some important back-translation fixes for UEB.
* brailleInput is now notified when reverting config or changing config profiles. This is necessary because brailleInput now maintains some state when the input table is changed.
* brailleInput is now initialised before braille at startup. This is because braille depends on brailleInput to get the currently untranslated input.
* Dot7 and dot8 are now universally bound to braille input specific scripts for erase and enter. Any braille display drivers that had bindings for backspace/enter for braille input have been adjusted accordingly.
* In the User Guide, a "Braille" section has been added above "Application Specific Features". The "Braille Control Types and States" section has been moved to a sub-section of this, and a sub-section on Braille Input has been added.
* Added a Unicode braille input table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment