New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all shape types in Microsoft Powerpoint #7111

Closed
michaelDCurran opened this Issue Apr 28, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@michaelDCurran
Contributor

michaelDCurran commented Apr 28, 2017

Currently NVDA provides a role of 'shape' to any item on a Powerpoint slide that cannot be mapped directly to one of the other standard NVDA roles (E.g. table, textFrame, chart, embeddedObject etc).
However, there are over 180 shapes (including rectangles, triangles, arrows, clouds etc) that can be placed on a Powerpoint slide. Most if not all are usually used to convey particular meaning, not just for artistic reasons.
Therefore, NVDA should speak / braille these shape types, rather than just 'shape'.
To do this, we should introduce the idea of a roleText property, which can be a way for an NVDAObject to provide custom text for the role, where the role is too particular for any NVDA standard role. ARIA roleDescription can eventually use this concept as well.
A part from these particular shapes, specific NVDA roles should be added for audio and video, as these are PowerPoint shapes that are pretty well understood concepts and would most likely be made use of outside of Powerpoint.

@michaelDCurran michaelDCurran self-assigned this Apr 28, 2017

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone May 31, 2017

michaelDCurran added a commit that referenced this issue May 31, 2017

In Microsoft Powerpoint, the exact type of a shape is now reported wh…
…en editing a slide (Examples include: triangle, circle, video, arrow), rather than just 'shape'. (#7111)

* Add audio and video roles to NVDA.

* Add a 'roleText' property to NVDAObjects. If its value is a string,  this string is used in place of the label looked up from the 'role' property, in both speech and braille, allowing an NVDAObject to override the presented role.

* Powerpoint: ensure that all shape types are presented to the user in speech and braille.
This Includes mapping  media shapes to audio and video roles, and for all other shapes, exposing localizable label as role text, keeping the actual role still as shape.
For action button shapes, the action is now exposed via the name property.
We also no longer expose the programmatic name of the shape, as this was usually wrong and was only done in the past as a hope of giving some guess as to the shape type.

* Remove accidental symbols in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment