Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different cursor shapes for braille tethered to focus or review. #7122

Closed
dkager opened this Issue Apr 30, 2017 · 10 comments

Comments

Projects
None yet
6 participants
@dkager
Copy link
Collaborator

dkager commented Apr 30, 2017

To avoid confusion between the two, notably in editable text.
The cursor shape can already be set, see #5198.

@derekriemer

This comment has been minimized.

Copy link
Collaborator

derekriemer commented May 1, 2017

I think this is a useful PR. I have fallen into this trap several times and as seen in #7117 I actually mistook it for a bug in next. This shows how easy it is for the user to be deceived.

@derekriemer

This comment has been minimized.

Copy link
Collaborator

derekriemer commented May 1, 2017

fixes #7117

@derekriemer derekriemer changed the title Allow different cursor shapes for braille tethered to focus or review Allow different cursor shapes for braille tethered to focus or review. fixes #7117 May 1, 2017

@derekriemer derekriemer changed the title Allow different cursor shapes for braille tethered to focus or review. fixes #7117 Allow different cursor shapes for braille tethered to focus or review. May 1, 2017

@dkager

This comment has been minimized.

Copy link
Collaborator Author

dkager commented May 1, 2017

Note that there is no patch (PR) yet, though that shouldn't be too hard.

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented May 2, 2017

Can you please suggest a UX for this? For instance:

  • do you have cursor shapes in mind for each of these modes?
  • would you suggest that the cursor shapes be configurable by the user for each of these modes?
@dkager

This comment has been minimized.

Copy link
Collaborator Author

dkager commented May 2, 2017

  • do you have cursor shapes in mind for each of these modes?

Yes.

  • would you suggest that the cursor shapes be configurable by the user for each of these modes?

Yes.

NVDA already has the ability to configure the cursor shape. I suggest changing this from one combobox "Cursor shape" into two comboboxes:

  1. Cursor shape for focus
  2. Cursor shape for review

These can both take all values of braille.CURSOR_SHAPES. I suggest dots 7&8 as default for focus and dot 8 as default for review (very loosely based on JAWS). If a user wants the current behavior, i.e. the same shape for both modes, then she can configure the two comboboxes to be the same.

One thing I have not yet thought about is if browse mode should have its own cursor shape option. I'm tempted to say no.

@dkager

This comment has been minimized.

Copy link
Collaborator Author

dkager commented May 12, 2017

In conclusion, do we think this is worth a patch so we can see how it goes?

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented May 15, 2017

Thanks for clarifying that for us. We are happy to take a pull request to implement this feature.

@dkager

This comment has been minimized.

Copy link
Collaborator Author

dkager commented May 15, 2017

Almost done. I have one question though. Do we call it "Cursor shape for focus/review" or "Focus/Review cursor shape"? I went for the first because the latter makes it sound like NVDA has a "focus cursor", which it doesn't explicitly have. But it is a bit shorter.

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented May 15, 2017

I'd go for "Cursor shape for focus and "Cursor shape for review cursor".

@jcsteh

This comment has been minimized.

Copy link
Contributor

jcsteh commented May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.