Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cursor manager selection bugs #1. #7157

Closed
derekriemer opened this issue May 8, 2017 · 8 comments
Closed

More cursor manager selection bugs #1. #7157

derekriemer opened this issue May 8, 2017 · 8 comments
Assignees
Labels
p2
Milestone

Comments

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented May 8, 2017

  1. paste this into the python console.
    api.copyToClip(u"d\n"*30)
  2. Paste the result into instantbird (Do it to yourself, not someone else).
  3. press enter.
  4. Press control+end, and then shift up arrow about 5 times (Any number should work).
  5. press shift+home and shift+end. Nothing happens.
    Expected: if shift+end is pressed, line n-k is unselected.
    Actual: nothing.
@derekriemer derekriemer changed the title More cursor manager selection bugs. More cursor manager selection bugs #1. May 8, 2017
@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 8, 2017

Simplified STR:

  1. Open this URL in Firefox: data:text/html,ab
  2. In browse mode, press control+home.
  3. Press right arrow to move to "b".
  4. Press shift+end.
    • Expected: "b selected"
    • Actual: Nothing.

In short, shift+end does not work if the caret is at the last character of the line.

Not a regression: also fails in 2016.3.

@leonardder
Copy link
Collaborator

@leonardder leonardder commented May 9, 2017

@jcsteh: Will this pr also fix selection on lines with only one character?
I belief the issue I reported in #7162 is related to this.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 9, 2017

@leonardder commented on 9 May 2017, 8:29 pm AEST:

@jcsteh: Will this pr also fix selection on lines with only one character?

Steps to reproduce please? I don't quite understand what you're asking.

jcsteh added a commit that referenced this issue May 10, 2017
…end. Incubates #7159 (issue #7157).
@leonardder
Copy link
Collaborator

@leonardder leonardder commented May 10, 2017

Steps to reproduce please?

  1. go to google.com
  2. Type "a" in the edit field
  3. In browse mode, do home and try to select "a", which is the only character on the line

This didn't work before, but it seems that #7159 fixes this as well, as I can't reproduce this in latest next.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 10, 2017

@bhavyashah
Copy link

@bhavyashah bhavyashah commented May 10, 2017

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented May 10, 2017

@leonardder
Copy link
Collaborator

@leonardder leonardder commented May 16, 2017

Were you trying to select with shift+end?

Yes, that is what I did. Glad this has been taken care of.

@jcsteh jcsteh closed this in #7159 Jun 1, 2017
@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jun 1, 2017
jcsteh added a commit that referenced this issue Jun 1, 2017
… using shift+end even when the caret is on the last character of the line. (issue #7157, PR #7159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.