Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include applications, dialogs and audio/video tags in embedded object quick navigation #7239

Closed
leonardder opened this issue Jun 1, 2017 · 4 comments
Labels
Milestone

Comments

@leonardder
Copy link
Collaborator

@leonardder leonardder commented Jun 1, 2017

Embedded objects based on the html object tag are getting more rare these days. There are two things I see happening more regularly:

  1. Applications embedded inside a document, e.g. MediaElement.js audio and video players. You can find at least two players on this page using the application role. I'm not sure whether this meets the accessibility standard, it's just that they seem to have implemented it this way. Other examples include rich text editors, which are in fact edit fields but they aren't accessible using quick nav. Since treating them as edit boxes will be quite difficult probably (you can't see whether an application is a richt text editor or not), I think object would be a nice alternative
  2. Websites that have dialogs embedded on them. Usually, those dialogs should receive focus automatically, but they often don't, which requires you to find the dialog using browse mode. Quick nav for this is something I'd certainly use.
@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Jun 12, 2017

@derekriemer: Given your comment in #124 (comment) , what do you think about this?

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented Jun 12, 2017

I think it would make sense.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jun 12, 2017

I think this makes sense, but please note that the command descriptions and User Guide needs to explicitly mention this in the appropriate places. Regarding the User Guide, from memory, you should check the section that lists first letter navigation keys, as well as the specific section on embedded objects.

@jcsteh jcsteh added feature p4 labels Jun 12, 2017
@leonardder leonardder changed the title Include applications and dialogs in embedded object quick navigation Include applications, dialogs and audio/video tags in embedded object quick navigation Jun 15, 2017
@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Jun 15, 2017

I opened a pr for this. When I saw the code for this, I noticed that it was very easy to also add audio and video tags in the process, at least for Gecko and MSHTML. Although I haven't discussed this in this issue, it seemed reasonable to add these in the process. Feel free to object this, it's not a problem at all to remove this.

@nvaccessAuto nvaccessAuto added this to the 2017.4 milestone Sep 5, 2017
@josephsl josephsl mentioned this issue Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.