New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA and Windows 10 Start Menu: reporting typed text after closing the menu #7370

Closed
fisher729 opened this Issue Jul 10, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@fisher729

fisher729 commented Jul 10, 2017

This is a long standing issue with NVDA.

  1. Open the Windows 10 Start menu.
  2. Type in the name of an app/program like' Notepad'. If you type 'Note' for example, that should be sufficient, and I recommend that because the issue would become easier to spot.
  3. Press Enter. The menu will close and something happens before Notepad starts.

Expected: NVDA just keeps quiet and Notepad starts.
Actual: NVDA says Note, Notepad etc. (whatever you typed) then starts the program as expected.

I have noticed this with:
NVDA as far back as 2015.3 to the latest Next snapshot.
Windows 10 as far back as 15240 to 15063.413 and still going.
Speak typed characters and words both on and off. It doesn't matter.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jul 10, 2017

Collaborator
Collaborator

josephsl commented Jul 10, 2017

@jcsteh

This comment has been minimized.

Show comment
Hide comment
@jcsteh

jcsteh Jul 11, 2017

Contributor

Actually, this is due to the enter key handler used to read automatically inserted text on the next line; e.g. automatic numbering in Word. It can be fixed by setting announceNewLineText to False for the search field.

P3 because it's superfluous but otherwise harmless, but should be fairly easy to fix.

Contributor

jcsteh commented Jul 11, 2017

Actually, this is due to the enter key handler used to read automatically inserted text on the next line; e.g. automatic numbering in Word. It can be fixed by setting announceNewLineText to False for the search field.

P3 because it's superfluous but otherwise harmless, but should be fairly easy to fix.

@jcsteh jcsteh added the p3 label Jul 11, 2017

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jul 11, 2017

Collaborator
Collaborator

josephsl commented Jul 11, 2017

@fisher729

This comment has been minimized.

Show comment
Hide comment
@fisher729

fisher729 Jul 11, 2017

fisher729 commented Jul 11, 2017

josephsl added a commit to josephsl/nvda that referenced this issue Jul 11, 2017

UIA/Search field: do not announce search field entry when searchui (s…
…tart menu) is closing. re #7370.

due to use of announceNewlineText, when start menu closes and when Enter is pressed, search field value will be announced, which sometimes leads to side effects such as core freeze. Address this through initOverClass in UIA.SearchField that turns this flag off if and only if we're in start menu in Windows 10.

josephsl added a commit to josephsl/nvda that referenced this issue Jul 11, 2017

SearchField/searchui: an overlay class just for Start menu version th…
…at disables announcement of newline text. re #7370.

Reviewed by Mick Curran (NV Access): better to create an overlay class for this just for searchui. This also allows easy modifications in the future if the need arises.

@nvaccessAuto nvaccessAuto added this to the 2017.3 milestone Jul 25, 2017

michaelDCurran added a commit that referenced this issue Jul 25, 2017

Pressing Enter to close Start menu in Windows 10 no longer results in…
… NVDA announcing search field text. re #7370. (#7375)

* UIA/Search field: do not announce search field entry when searchui (start menu) is closing. re #7370.

due to use of announceNewlineText, when start menu closes and when Enter is pressed, search field value will be announced, which sometimes leads to side effects such as core freeze. Address this through initOverClass in UIA.SearchField that turns this flag off if and only if we're in start menu in Windows 10.

* SearchField/searchui: an overlay class just for Start menu version that disables announcement of newline text. re #7370.

Reviewed by Mick Curran (NV Access): better to create an overlay class for this just for searchui. This also allows easy modifications in the future if the need arises.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment