Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braille Cursor routing bring to the next characther #7469

Closed
dreinn opened this Issue Aug 2, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@dreinn
Copy link

dreinn commented Aug 2, 2017

Steps to reproduce:

Open a text editor, I tried notepad, thunderbird new message and this edit field on Google Chrome.
Press a cursor routing.
The cursor will be positioned a charachter after your desired position.
For example if you have the word NVDA, and you want the cursor to the D charachter, after pressing cursor routing you will be positioned on the A charachter.
This behaviour is present also if you select braille tether review cursor, instead of focus.

Expected behavior:

Cursor should go to the proper charachter.

Actual behavior:

Cursor's position is one charachter after you expect.

System configuration:

NVDA version: next-14283,1e5c5581 (August 2, 2017).

NVDA Installed or portable: portable.

Other information:
running windows7 64bit with a Lilli display braille.

Name and version of other software in use when reproducing the issue:

Windows Notepad, Thunderbird38.

Other questions:

Does the issue still occur after restarting your PC? Yes.

Have you tried any other versions of NVDA? YES, 2017.2 is broken too.

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 2, 2017

@dreinn

This comment has been minimized.

Copy link
Author

dreinn commented Aug 2, 2017

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 2, 2017

@dreinn commented on 2 aug. 2017 16:25 CEST:

The problem is the same.

So it seems it has been there since the driver is there. Could you report what happens in Next if you press the cursor routing cell above cell 40?

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 2, 2017

@jcsteh: Any idea whether we can track down the original authors of this Lilly driver?

@jcsteh

This comment has been minimized.

Copy link
Contributor

jcsteh commented Aug 2, 2017

There are two names on the copyright line for this driver, and although we don't do this with newer code, they include email addresses as well. I guess you could try contacting them.

That said, this looks like it might be a simple off by one bug. I'm guessing the driver returns 1-based routing indexes, but we expect 0-based. That could be easily tested if we provide a try build which logs the routing index pressed, then have affected users press specific routing keys and provide the log.

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 3, 2017

@jcsteh commented on 3 aug. 2017 01:20 CEST:

That said, this looks like it might be a simple off by one bug. I'm guessing the driver returns 1-based routing indexes, but we expect 0-based.

Either that, or the key range that is reserved for routing according to the driver starts and ends one too high. The reserved key range is 257--296, Personally I'd start with 256 if I'd develop a protocol :) I also belief this is why hexadecimal values should be used for such numbers.

@dreinn

This comment has been minimized.

Copy link
Author

dreinn commented Aug 3, 2017

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 3, 2017

@leonardder

This comment has been minimized.

Copy link
Collaborator

leonardder commented Aug 3, 2017

Please try This NVDA build. If I'm correct, this fixes the cursor routing indexes. Please pay extra attention to the first and the last routing key.

@dreinn

This comment has been minimized.

Copy link
Author

dreinn commented Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.