Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Braille Cursor routing bring to the next characther #7469
Steps to reproduce:
Open a text editor, I tried notepad, thunderbird new message and this edit field on Google Chrome.
Cursor should go to the proper charachter.
Cursor's position is one charachter after you expect.
NVDA version: next-14283,1e5c5581 (August 2, 2017).
NVDA Installed or portable: portable.
Name and version of other software in use when reproducing the issue:
Windows Notepad, Thunderbird38.
Does the issue still occur after restarting your PC? Yes.
Have you tried any other versions of NVDA? YES, 2017.2 is broken too.
Hello, I have a very old NVDA 2014.2 installed on this pc, because I have no admin rights. The problem is the same. My table is italian 8 dots, but I tried to change it to German or English unified braille, same thing. Cursor routing is always one charachter after the proper position. So you assume it is a problem of lilli driver? I will ask some friends to make some tests about it, they have that display braille.
There are two names on the copyright line for this driver, and although we don't do this with newer code, they include email addresses as well. I guess you could try contacting them.
That said, this looks like it might be a simple off by one bug. I'm guessing the driver returns 1-based routing indexes, but we expect 0-based. That could be easily tested if we provide a try build which logs the routing index pressed, then have affected users press specific routing keys and provide the log.
Either that, or the key range that is reserved for routing according to the driver starts and ends one too high. The reserved key range is 257--296, Personally I'd start with 256 if I'd develop a protocol :) I also belief this is why hexadecimal values should be used for such numbers.
I made other test: if I press routing38, it goes to 39, according with the mentioned bug. Pressing 39 goes to 40. Pressing 40 has no effect! The cursor remains on the last position, it can be cell 2 if it was the last place. Pressing NVDA-1 and then cursor routing works well, because also 40 is announced as "route". Yesterday I talked with a friend of mine that has Lilli display braille, and he has same problem. We tried to understand if for some circumstances it could be an internal firmware issue, but with other screen readers, for example OSX, this issue is not present, so it should be a NVDA driver problem. Thanks for your patience!