New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA announces the last number of the typed pin on Windows 10 Lockscreen window #7908

Closed
amirsol81 opened this Issue Jan 15, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@amirsol81

amirsol81 commented Jan 15, 2018

If one selects to sign into Windows 10 by typing a pin (instead of typing a password or using a fingerprint), NVDA announces the last number of the pin instead of replacing it with an asterisk (star). This happens regardless of whether or not the typed pin is correct.
This is with Windows 10 Pro 64-Bit, all recent Win 10 releases, and NVDA 2017.4, 2017.3, and 2017.2.
Quite interestingly, this doesn't affect the "Password" option.

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jan 15, 2018

Collaborator
Collaborator

josephsl commented Jan 15, 2018

@josephsl

This comment has been minimized.

Show comment
Hide comment
@josephsl

josephsl Jan 15, 2018

Collaborator

Hi,

Technical: this is because there is no "submit" button when entering a pin, whereas password field does. This means the last character will be spoken, as winlogon will immediately validate the pin as soon as last pin character is entered. This is an unintended side effect from #6017.

To confirm that this is indeed the side effect from keyboard handler changes made recently, can you try with NVDA 2016.4 and 2017.1 and see if NVDA even announces pin entries or asterisks?

Thanks.

Collaborator

josephsl commented Jan 15, 2018

Hi,

Technical: this is because there is no "submit" button when entering a pin, whereas password field does. This means the last character will be spoken, as winlogon will immediately validate the pin as soon as last pin character is entered. This is an unintended side effect from #6017.

To confirm that this is indeed the side effect from keyboard handler changes made recently, can you try with NVDA 2016.4 and 2017.1 and see if NVDA even announces pin entries or asterisks?

Thanks.

@amirsol81

This comment has been minimized.

Show comment
Hide comment
@amirsol81

amirsol81 Jan 15, 2018

amirsol81 commented Jan 15, 2018

michaelDCurran added a commit that referenced this issue Feb 12, 2018

Move the logic from api.isTypingProtected() into the base NVDAObject'…
…s isProtected property.

However,  the isProtected property now also cashes any positive result. I.e. If the object has protected at least once, then it stays protected for its lifetime.
Fixes #7908

@nvaccessAuto nvaccessAuto added this to the 2018.1 milestone Mar 6, 2018

michaelDCurran added a commit that referenced this issue Mar 6, 2018

@michaelDCurran michaelDCurran modified the milestones: 2018.1, 2018.2 Mar 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment