Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysListView32.ListItem._getColumnLocationRaw can return malformed rectangles (i.e. with a left coordinate that is greather than the right coordinate) #8268

Closed
lukaszgo1 opened this issue May 15, 2018 · 6 comments · Fixed by #9873
Milestone

Comments

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented May 15, 2018

Steps to reproduce:

  1. Install NVDA Version: next-15126,d5e58ddf
  2. Launch Becky! Internet Mail and focus a list of messages.
  3. Try to navigate with arrow keys.

Expected behavior:

NVDA should read list columns such as subject send date and from

Actual behavior:

An error sound is played. I am attaching a fragment of the log with specific error.

System configuration:

NVDA version:
next-15126,d5e58ddf

NVDA Installed or portable:
Installed
Other information:
It is probably caused by #8190. The problematic column seems to be the first column, which contain graphical presentation of the message state read, unread etc. I am also attaching developer info for this column.

Windows version:
Windows 8 x64

Name and version of other software in use when reproducing the issue:
Becky! Internet Mail version 2.74 [en]

Other questions:

Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
Yes next 15121,7fcd6fe7 and it was possible to read this list.
Issue.zip

@leonardder
Copy link
Collaborator

leonardder commented May 15, 2018

This is caused by #7537, which introduces the new locationHelper module. It looks like sysListView32.ListItem._getColumnLocationRaw can return malformed rectangles (i.e. with a left coordinate that is greather than the right coordinate). This really should not be the case for these rectangles. In any case, this code is slightly complex and fixing that as part of #7537 might be quite error prone, so I reverted _getColumnLocationRaw to the stage before locationHelper for now. I think we should leave it as is for now, but we should keep this issue open in order to investigate why _getColumnLocationRaw returns a rectangle that we do not expect.

@leonardder
Copy link
Collaborator

leonardder commented May 15, 2018

@lukaszgo1: Could you please try this again with the latest version of next?

@lukaszgo1
Copy link
Contributor Author

lukaszgo1 commented May 15, 2018

@leonardder Latest next fixes it. Thanks.

@leonardder leonardder changed the title NVDA Version next-15126,d5e58ddf no longer possible to read list in Becky! Internet Mail sysListView32.ListItem._getColumnLocationRaw can return malformed rectangles (i.e. with a left coordinate that is greather than the right coordinate) May 15, 2018
@derekriemer
Copy link
Collaborator

derekriemer commented May 16, 2018

should this be closed now?

@derekriemer
Copy link
Collaborator

derekriemer commented May 16, 2018

never mind, I think not.

@leonardder
Copy link
Collaborator

leonardder commented May 23, 2018

Hmm, I was able to reproduce this with Becky. When I use UIA for syslistview32,, the location for the particular column turns out to be different and according to the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants