Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching a new copy of NVDA should exit running version and start launched version. #8320

Closed
Qchristensen opened this issue May 22, 2018 · 14 comments · Fixed by #9827
Closed

Launching a new copy of NVDA should exit running version and start launched version. #8320

Qchristensen opened this issue May 22, 2018 · 14 comments · Fixed by #9827
Milestone

Comments

@Qchristensen
Copy link
Member

@Qchristensen Qchristensen commented May 22, 2018

(Updated with command line information from Leonard).

This is a minor inconsistency, but still worth recording:

With any version of NVDA running, pressing control+alt+n restarts the installed copy of NVDA. That works fine.

If a desktop or start menu shortcut to NVDA is instead activated, or a copy of NVDA run from File Explorer, NVDA does not restart. NVDA does have a command line parameter -r to replace or quit the running version of NVDA and start this one (Thanks Leonard for reminding me of that!)

See https://www.nvaccess.org/files/nvda/documentation/userGuide.html#CommandLineOptions for more information on the command line options.

I would like to then propose that we make the -r parameter implicit and adopt that behaviour by default, and perhaps in its place add a parameter to check and return a value if there is already a copy of NVDA running to enable both functionalities going forward.

@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented May 22, 2018

@leonardder
Copy link
Collaborator

@leonardder leonardder commented May 22, 2018

The reason why NVDA restarts with the control+alt+n shortcut, is because the "-r" parameter is provided to the executable. This parameter closes a running copy of NVDA and then starts a new one. Adding the -r command line parameter should solve your issue.

Having said that, I agree that it could be considered to have this restarting behaviour by default.

@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented May 22, 2018

@derekriemer
Copy link
Collaborator

@derekriemer derekriemer commented May 23, 2018

having a restart implicit could be very nice indeed.

@michaelDCurran
Copy link
Member

@michaelDCurran michaelDCurran commented May 31, 2018

I can support this if that is what most people would prefer. The original idea however was that the user had to be quite specific about launching any random copy of NVDA and replacing the old one, just in case they accidentally executed the file.

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jun 27, 2019
 * An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
@JulienCochuyt
Copy link
Collaborator

@JulienCochuyt JulienCochuyt commented Jun 27, 2019

For a non-initiated user, I think it is less common to accidentally run an executable that it is to stumble upon trying to replace the current running NVDA with a portable version already created.

I already had a few hard times trying to remote assist grand beginners in accomplishing this task.

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jun 27, 2019
 * An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
	* Command Line Options
@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Jun 27, 2019

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Jul 15, 2019
 * An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
    * Command Line Options
@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Jul 16, 2019

So, is this still being considered? In other words: bump.:)

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jul 16, 2019

@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Jul 16, 2019

@JulienCochuyt has already written a PR for this--a month or so ago, and an update yesterday.

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jul 16, 2019

@XLTechie
Copy link
Contributor

@XLTechie XLTechie commented Jul 16, 2019

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Aug 13, 2019
 * An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
    * Command Line Options
JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Aug 13, 2019
 * An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
    * Command Line Options
michaelDCurran pushed a commit that referenced this issue Sep 9, 2019
* An already running NVDA is always terminated, unless -k|--check-running
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
    * Command Line Options
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Sep 9, 2019
@josephsl
Copy link
Collaborator

@josephsl josephsl commented Sep 10, 2019

Hi,

I'm going to reopen this to serve as a reminder as to the tough road ahead: see #10179 for a full explanation, as the design of this issue includes an unintended side effect for installed copy of NVDA when it comes out of secure screens.

Thanks.

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Sep 10, 2019

A fix up for #10179 is provided in #10183. Thus, closing this one in favor of the both references. I suggest to reopen the feature requests only if the whole feature is implemented and reverted due to something. If there is only a bug due to the feature but the feature is not completely reverted, then I suggest to open new issues like in this case #10179. If there are more bugs discovered based on this feature, then we should think about reverting the whole feature and then we can reopen this one again.
Thanks.

JulienCochuyt added a commit to accessolutions/nvda that referenced this issue Sep 16, 2019
 * Backport of nvaccess#9827
 * An already running NVDA is always terminated, unless -k|--check-running or --ease-of-access (nvaccess#10179)
 * -q|--quit and -k|--check-running are now mutually exclusive
 * Updated User Guide
    * Launching NVDA
    * Command Line Options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants