New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft Edge: Reading View notification is not announced #8423

Closed
josephsl opened this Issue Jun 20, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@josephsl
Collaborator

josephsl commented Jun 20, 2018

Hi,

Microsoft Edge comes with Reading view, a way to reformat the current page for smooth reading. However, NVDA does not announce certain notifications about it, including on pages where this view is not supported. Investigation shows this is tied to notification event introduced in IUIA5.

Steps to reproduce:

  1. Open Google with Edge.
  2. Press Control+Shift+R to enable reading view.

Please also remember to attach a zip of any files required to reproduce the issue.

Expected behavior:

NVDA announces, "reading view is not available for this page".

Actual behavior:

No announcement.

System configuration:

NVDA next.15316 (installed), Windows 10 April 2018 Update.

Other questions:

Reproducible: yes.
Did restart help: no.

Technical details:

Certain notifications are sent via UiaRaiseNotificationEvent (see #7984 for details), and reading view announcement is one of them. At the moment NVDA checks to make sure focused control is part of the active application where the notification came from, but Edge uses at least two processes when run:

  • MicrosoftEdge.exe: main process.
  • MicrosoftEdgeCP.exe: content process.

Notifications are sent by the first process, thus failing the notification announcement criteria.

Solution:

The Edge app module (microsoftedge.py) will gain notification event handler that'll announce all messages. This was tested on Windows 10 App Essentials add-on and was successful.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Jun 20, 2018

Edge: announce notifications fired by main Edge process such as readi…
…ng view availability. Re nvaccess#8423.

Certain notifications, including reading view availability are fired by main Edge process, not the content process. This means NvDA will ignore such notifications. Resolved by adding a dedicated app module for Edge main process that'll catch notifications and announce them, and propogate them no more.

josephsl added a commit to josephsl/nvda that referenced this issue Jun 21, 2018

Edge: review actionn (limit notificaiton context to Edge). Re nvacces…
…s#8423.

Reviewed by @leonardder: limit Edge notificaiton context to Edge only. This is done by checking to make sure focused element is indeed part of Edge, and if not, notifications will be silenced. This resolves an issue where Edge notifications are heard while using other apps.

@nvaccessAuto nvaccessAuto added this to the 2018.3 milestone Jul 27, 2018

michaelDCurran added a commit that referenced this issue Jul 27, 2018

Edge: announce notifications fired by main Edge process such as readi…
…ng view availability (#8424)

* Edge: announce notifications fired by main Edge process such as reading view availability. Re #8423.

Certain notifications, including reading view availability are fired by main Edge process, not the content process. This means NvDA will ignore such notifications. Resolved by adding a dedicated app module for Edge main process that'll catch notifications and announce them, and propogate them no more.

* Edge: review actionn (limit notificaiton context to Edge). Re #8423.

Reviewed by @leonardder: limit Edge notificaiton context to Edge only. This is done by checking to make sure focused element is indeed part of Edge, and if not, notifications will be silenced. This resolves an issue where Edge notifications are heard while using other apps.

* Update what's new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment