Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce search history in NvDA Find dialog #8482

Open
josephsl opened this issue Jul 6, 2018 · 3 comments · Fixed by #8921

Comments

@josephsl
Copy link
Collaborator

commented Jul 6, 2018

Hi,

This is the "issueformation" (combination of the words "issue" and "transformation") of the PR #6484:

Rationale

Suppose one wishes to find multiple texts from different applications. Currently, in order to find new text in any application that supports cursor manager, users must enter the new text. In case users may wish to find something they've searched before, a search history in the form of a combo box should be provided.

Steps to reproduce:

  1. Open multiple document windows (web browsers, PDF documents, several Word documents and such), all with browse mode turned on.
  2. While using one of them, press Control+NVDA+F to open Find dialog.
  3. Search for some text and press Enter.
  4. Reopen Find dialog (instead of using find next/previous command) and search for another text.
  5. Repeat step 4.

Actual behavior:

Users must enter new text again.

Expected behavior:

Users can choose items from search history.

System configuration:

NVDA Installed/portable/running from source:

Installed

NVDA version:

Alpha/future version

Windows version:

Windows 10 Version 1803

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes (perpetual as this is a new feature)

Technical details

One way to implement this is via wx.ComboBox and hosting search history (a list/priority queue) inside Cursor Manager class (the base class, that is). When Find dialog opens, present this combo box with entries coming from search history list, with find next (NvDA+F3)/previous (NVDA+Shift+F3) searching the topmost item.

Special corner case: what if users type something that NVDA knows is already part of search history (the whole text, that is)? If so, bump this text to the top if it isn't.

Another case: suppose there is already an entry in search history and the user types the same entry that only differs in case. If so, the best path might be to compare the texts regardless of case, or if case sensitivity is turned on, just prepend the new variant.

For a code example, see StationPlaylist Studio add-on.

Thanks.

@amirsol81

This comment has been minimized.

Copy link

commented Jul 7, 2018

I also support the implementation of this handy feature.

@marlon-sousa

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

PR #8921 opened and ready for review.

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Mar 22, 2019

feerrenrut added a commit that referenced this issue Mar 22, 2019
History in search dialog (PR #8921)
Adds history to the Search list in find dialog
- Limit size of search history to 20 items
- Search history is not saved between restarts of NVDA
Closes #8482
@Adriani90

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

I am reopening this issue since the PR has been reverted.
@josephsl, @feerrenrut, @leonardder and others, please when reverting a feature or something that was related to an issue, please don't forget to reopen the issues. Thanks.
Reverting for this one was in PR #9993.

@Adriani90 Adriani90 reopened this Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.