Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle selectable checkboxes as list items when speaking selected state #8554

Closed
LeonarddeR opened this issue Jul 24, 2018 · 3 comments · Fixed by #8858
Closed

Handle selectable checkboxes as list items when speaking selected state #8554

LeonarddeR opened this issue Jul 24, 2018 · 3 comments · Fixed by #8858
Milestone

Comments

@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Jul 24, 2018

cc @dkager

Steps to reproduce:

  1. Open windows disk cleanup by typing cleanmgr in the run window.
  2. Select a drive if applicable
  3. Use arrow keys and object navigation in the resulting list.

Actual behavior:

For a focused (selected) item, NVDA says: Downloaded Program Files check box selected checked 0 bytes 1 of 10
For an unselected item, NVDA says: Downloaded Program Files check box checked 0 bytes 1 of 10

Expected behavior:

For a focused (selected) item, NVDA says: Downloaded Program Files check box checked 0 bytes 1 of 10
For an unselected item, NVDA says: Downloaded Program Files check box not selected checked 0 bytes 1 of 10

@DrSooom
Copy link

DrSooom commented Jul 24, 2018

There are four possible states for checkboxes in a list:

  1. selected and checked
  2. unselected and checked
  3. selected and unchecked
  4. unselected and unchecked

Don't forget that you can move the (focus) cursor in a list (e.g. Windows Explorer, Details View) via the CTRL key as well.

Furthermore please add additional information about NVDA Version and OS because the cleanmgr could be different between Win7 and Win10-1803. Thanks.

@dkager
Copy link
Collaborator

dkager commented Jul 25, 2018

I would argue that (not) selected applies to the list item as a whole while (un)checked applies to the checkbox.
Trying to generalize this a bit. What this issue seems to say is that "selected" should be the implicit state. That is, NVDA should not announce "selected" but should announce "not selected".

@LeonarddeR two questions:

  1. Is this correct?
  2. If so, will it work? Or if not, then what did you mean?

@LeonarddeR
Copy link
Collaborator Author

@dkager commented on 25 jul. 2018 12:44 CEST:

I would argue that (not) selected applies to the list item as a whole while (un)checked applies to the checkbox.

I agree. However, a checkable list item can have only one role, and this happens to be checkbox for disk clean up.

Trying to generalize this a bit. What this issue seems to say is that "selected" should be the implicit state. That is, NVDA should not announce "selected" but should announce "not selected".

@LeonarddeR two questions:

  1. Is this correct?

Yes.

  1. If so, will it work? Or if not, then what did you mean?

I'd say that it might work, however I'm unsure of whether non list item check boxes could have the selectable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants