Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a command line parameter to disable start at logon screen for silent installations #8574

Closed
leonardder opened this Issue Jul 30, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@leonardder
Copy link
Collaborator

leonardder commented Jul 30, 2018

Steps to reproduce:

  1. Install NVDA with the --install-silent flag
  2. Restart the system.

Actual behavior:

NVDA runs at the logon screen.

Expected behavior:

NVDA shouldn't run at the logon screen when explicitly chosen to install silent.

Additional details

This issue is relevant for system administrators who want to install NVDA silently on a multi user system. IN the current situation, it is not possible to specify the start at logon behaviour from the command line. I think it makes sense to make False the default for first time silent installations. Alternatively, we could consider introducing a new command line parameter.

cc @michaelDCurran, @feerrenrut, @derekriemer

System configuration:

Not applicable. This issue is unrelated to the Windows version of use and I believe it has been there since the --install-silent parameter was introduced.

@leonardder leonardder changed the title When performing a first time silent installation of NVDA< disable start at logon screen When performing a first time silent installation of NVDA, disable start at logon screen Jul 30, 2018

@michaelDCurran

This comment has been minimized.

Copy link
Contributor

michaelDCurran commented Jul 30, 2018

@feerrenrut

This comment has been minimized.

Copy link
Contributor

feerrenrut commented Aug 6, 2018

@michaelDCurran & @leonardder I would expect that the majority or silent installs do not require NVDA on log on, but not all. However, I'm concerned that changing the behaviour here could break some install processes somewhere. So I would advise on keeping the current default, and adding a new option to --disable-start-at-logon. If everyone agrees, then perhaps we can change the title / description of this issue?

@leonardder leonardder changed the title When performing a first time silent installation of NVDA, disable start at logon screen Add a command line parameter to disable start at logon screen for silent installations Aug 11, 2018

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

leonardder commented Aug 11, 2018

@feerrenrut: Sound sreasonable. I will follow these implementation guidelines.

Note that the default will enable NVDA at logon, unless this is not a first installation and NVDA has been disabled at the logon screen. However, when this config parameter is provided, I tend to force disable NVDA at logon, so ignoring the current state of the setting.

@nvaccessAuto nvaccessAuto modified the milestone: 2018.4 Dec 13, 2018

feerrenrut added a commit that referenced this issue Dec 13, 2018

Add command line parameter for silent installations to disable NVDA a…
…t the logon screen and enhance portable-path command line behavior (PR #8623)

Fixes #8574

### Summary of the issue:
1. In the current situation, it is not possible to specify the start at logon behaviour from the command line. This issue is relevant for system administrators who want to install NVDA silently on a multi user system.
2. When starting NVDA with the `--portable-path` command line parameter and creating a portable copy from the GUI, the provided portable path isn't shown in the gui as one might expect.

### Description of how this pull request fixes the issue:
1. Added a `--enable-start-on-logon` command line parameter. It should be specified as `--enable-start-on-logon=True` or `--enable-start-on-logon=False`, just `--enable-start-on-logon` will show an error message. Alternative supported values are `yes/no`, `on/off`, `1/0` (i.e.  this option behaves as `configobj boolean`). NVDA's behaviour is to default this to `True`
2. When the `--portable-path` parameter is provided at NVDA start, the provided path is now pre-filled in in the portable copy creation dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.