Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot scroll braille after using command to read character #8682

Closed
mehgcap opened this issue Aug 27, 2018 · 6 comments · Fixed by #13718
Closed

cannot scroll braille after using command to read character #8682

mehgcap opened this issue Aug 27, 2018 · 6 comments · Fixed by #13718

Comments

@mehgcap
Copy link

mehgcap commented Aug 27, 2018

Steps to reproduce:

  1. Connect a braille display. I'm using an Orbit Reader 20 connected via USB.
  2. Open an application that allows character review. I've tested a webpage on Chrome and a file in Notepad Plus Plus. I suspect anywhere will work, though.
  3. Make sure you can scroll. Your text should be more than the length of your display, and your scroll buttons should move display width by display width as normal.
  4. Now press NVDA-period (I'm using the laptop keyboard layout).
  5. Now try to scroll using the panning keys on your display, the ones you verified worked in a previous step.

Actual behavior:

Braille does not pan. The display remains on the current line until you move the cursor with the keyboard.

Expected behavior:

Braille should pan as normal.

System configuration:

NVDA Installed/portable/running from source:

Installed.

NVDA version:

2018.2.1

Windows version:

Windows 10, v1803

Name and version of other software in use when reproducing the issue:

Chrome, Notepad Plus Plus, suspect software doesn't matter

Other information about your system:

Nothing pertinent.

Other questions:

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA?

No.

@LeonarddeR
Copy link
Collaborator

cc @dkager

@dkager
Copy link
Collaborator

dkager commented Aug 28, 2018

I can only reproduce this:

  1. outside browse mode; and
  2. with braille tethered automatically.

@mehgcap
Copy link
Author

mehgcap commented Aug 28, 2018

I can get this to happen regardless of the browse mode status. It happens on webpages when arrowing through them, and it happens in edit fields when editing. You're right, though, that tethering to focus does make the issue disappear. Only automatic seems to be affected.

@mehgcap
Copy link
Author

mehgcap commented Sep 25, 2018

Update: this issue is still present in NVDA 2018.3.1, with the same display setup as in the original report.

@LeonarddeR
Copy link
Collaborator

The question is what's the bug here:

  1. When you press NVDA+period, braille automatically tethers to review, since the script deals with reporting the character where the review cursor is situated, this may be expected from auto tethering.
  2. Now if your review cursor is in object review, scrolling should still work within notepad++, but it should move the review cursor, not the physical caret. When in browse mode and you are in object review, it is expected that you can't scroll beyond the edges of the object.

Basically, the scrolling behaviour after pressing NVDA+period should be similar to the review cursor next/previous line commands, until you explicitly move your physical caret again.

@Adriani90
Copy link
Collaborator

@mehgcap how is the behavior in NVDA 2019.3 Beta 1?

seanbudd pushed a commit that referenced this issue May 24, 2022
…, allow panning after review commands (#13718)

Fixes #8682
Fixes #11519

Summary of the issue:
#8682: when using the read_currentLine, read_currentWord, and read_currentCharacter commands after the caret has been moved, it is impossible to pan the Braille display through the displayed content.
#11519: when moving the mouse with Mouse Tracking on (default) and Braille Tether set to Auto (default), using read_currentLine, read_currentWord, and read_currentCharacter speaks content under the mouse, but does not update the Braille display with the spoken content.

Description of how this pull request fixes the issue:
These three global review functions all call braille.handler.setTether early in their processing. braille.handler.setTether clears the display buffer, making it impossible to scroll through the displayed content. braille.handler.setTether also does not update the display, causing the problems discussed in #11519 -- tether flags are set properly, but the display does not change. A simple call to braille.handler.handleReviewMove in all three cases solves both of these issues.
@nvaccessAuto nvaccessAuto modified the milestone: 2022.2 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants