New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Foxit Reader PDF Viewer #8944

Closed
gauldoth opened this Issue Nov 14, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@gauldoth
Contributor

gauldoth commented Nov 14, 2018

Foxit Reader is a widely used PDF viewer all over the world. Foxit also engages in providing accessibile PDF reading.
Foxit Reader can work with JAWS since version 9.3, it will be great if NVDA can support it.

Steps to reproduce:

  1. Download and install Foxit Reader 9.3, it can be downloaded from here:
    https://www.foxitsoftware.com/pdf-reader/
  2. Open a PDF document.
  3. Press DownArrow multiple times to read the contents in the opened document.

Actual behavior:

Could not enter browse mode, only the first line of the opened document is read.

Expected behavior:

Enter browse mode automatically and read the contents in the document.

System configuration:

NVDA Installed/portable/running from source:

Installed

NVDA version:

Version: 2018.3.2

Windows version:

N/A

Name and version of other software in use when reproducing the issue:

Foxit Reader 9.3.0.10826

Other information about your system:

N/A

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes

Additional info:

Foxit Reader implemented MSAA and PDDom model just as Adobe Reader does, only a few lines of modification is needed to support it. I will try to create a pull request in a few days.

@Brian1Gaff

This comment has been minimized.

Brian1Gaff commented Nov 14, 2018

@leonardder

This comment has been minimized.

Collaborator

leonardder commented Nov 14, 2018

Foxit Reader exposes a UIA document implementation. It is pretty easy to add browse mode to this and I was even able to have quick navigation working for headings, but the performance is ridiculously slow.

See https://github.com/BabbageCom/nvda/blob/i8944/source/appModules/foxitreader.py

@gauldoth

This comment has been minimized.

Contributor

gauldoth commented Nov 14, 2018

It may of course have changed or maybe Jaws has a specific script for it?

Yes, Foxit Reader has implemented MSAA and PDF Dom interface in version 9.3.
JAWS has changed it's config file and used the same interface as with Adobe Reader to access it.

@gauldoth

This comment has been minimized.

Contributor

gauldoth commented Nov 14, 2018

@leonardder The UIA implementation is not complete yet. Out of process queries are quite slow due to some unknown reasons. But their developers have implemented both MSAA and PDDom for the document, the UIA implementation may be removed in future releases.

@leonardder

This comment has been minimized.

Collaborator

leonardder commented Nov 14, 2018

@gauldoth commented on 14 Nov 2018, 14:39 CET:

@leonardder The UIA implementation is not complete yet. Out of process queries are quite slow due to some unknown reasons. But their developers have implemented both MSAA and PDDom for the document, the UIA implementation may be removed in future releases.

Thanks for pointing out. I will try another approach shortly.

@gauldoth

This comment has been minimized.

Contributor

gauldoth commented Nov 15, 2018

@leonardder Thanks for helping.
I also tried a commit, but I don't know how to put that in into app module, see gauldoth@8a56c93

BTW, there is another product called Foxit PhantomPDF which implemented the same interface.
If we are going to use app module, we may also need a foxitphantompdf.py under the appModules folder.

@leonardder

This comment has been minimized.

Collaborator

leonardder commented Nov 15, 2018

I also tried a commit, but I don't know how to put that in into app module, see gauldoth@8a56c93

Wow, this is exactly the next approach I intended to follow.
Would you be able to create a separate branch for this and file a pull request?

@nvaccessAuto nvaccessAuto added this to the 2018.4 milestone Nov 18, 2018

michaelDCurran added a commit that referenced this issue Nov 18, 2018

Add support for Foxit Reader and Foxit PhantomPDF (#8944) (#8947)
* Add support for Foxit Reader and Foxit PhantomPDF (#8944)

* Address review comments.

* Update what's new.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment