Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wx.Locale: Aragonese does not have wx.LanguageInfo #9089

Closed
josephsl opened this issue Dec 18, 2018 · 6 comments
Closed

wx.Locale: Aragonese does not have wx.LanguageInfo #9089

josephsl opened this issue Dec 18, 2018 · 6 comments

Comments

@josephsl
Copy link
Collaborator

josephsl commented Dec 18, 2018

Hi,

Reported on NvDA translations mailing list and subsequently confirmed: NVDA 2018.4 fails to start properly if UI language is set to Aragonese.

Steps to reproduce:

  1. Install NVDA 2018.4 and current alpha.
  2. From NVDA settings/General, switch language to "Aragonese" and press Enter, and confirm if asked to restart.

Actual behavior:

The following traceback is recorded:

CRITICAL - main (11:26:22.013):
core failure
Traceback (most recent call last):
File "nvda.pyw", line 233, in
File "core.pyc", line 390, in main
AttributeError: 'NoneType' object has no attribute 'Language'

Expected behavior:

NVDA starts properly with language set to Aragonese.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2018.4

Windows version:

Windows 10 Version 1809

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes - alpha.16458.

Technical information:

Not all languages come with wx.LanguageInfo, and Aragonese is one of those that isnt' supported by wxPython natively. Thus see if wxLang itself is something and act accordingly.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Dec 19, 2018
… info. Re nvaccess#9089.

2018.4 regression: wxLang.Language fails in Aragonese because wxLang itself is None. There might be other languages where this might be the case. Thus only obtain wxLang.Language if and only if wxLang is indeed not None.
michaelDCurran pushed a commit that referenced this issue Jan 10, 2019
… info. Re #9089. (#9092)

2018.4 regression: wxLang.Language fails in Aragonese because wxLang itself is None. There might be other languages where this might be the case. Thus only obtain wxLang.Language if and only if wxLang is indeed not None.
@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Jan 10, 2019
@Adriani90
Copy link
Collaborator

Adriani90 commented Jan 10, 2019

we have reports from the translator that it works fine now. So I think this issue can be closed and can be reopened if it is being reported again.

@ehollig
Copy link
Collaborator

ehollig commented Jan 10, 2019

Fixed from #9092. This was not automatically closed because it went into RC for NVDA 2018.4

@ehollig ehollig closed this as completed Jan 10, 2019
@josephsl
Copy link
Collaborator Author

josephsl commented Jan 10, 2019

Hi,

I'm overriding close status, as this fix is still being tested by some more. I'll close this once 2018.4.1 is released.

Thanks.

@josephsl josephsl reopened this Jan 10, 2019
@Adriani90
Copy link
Collaborator

Adriani90 commented Jan 19, 2019

@josephsl did you get further test results from users? Are there still issues with Aragonese or other languages?

@josephsl
Copy link
Collaborator Author

josephsl commented Jan 20, 2019

@Adriani90
Copy link
Collaborator

Adriani90 commented Jan 24, 2019

I have tested also on Windows 10 and 8.1 with NVDA 2018.4.1. Everything seems to work properly now. Closing this as works for me since it is also part of NVDA 2018.4.1. We can reopen it if users report this issue again. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants