Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composable Shell/emoji panel: search results for emojis are not announced #9105

Closed
josephsl opened this Issue Dec 26, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@josephsl
Copy link
Collaborator

commented Dec 26, 2018

Hi,

The following issue affects Windows 10 Fall Creators Update and later but is most prominent in October 2018 Update and later. This is another one of those that requires Windows 10 App Essentials add-on:

Steps to reproduce:

  1. Open emoji panel (Windows+period).
  2. Search for emojis by typing part of its name.

Actual behavior:

Only search result count is announced, or in Fall Creators Update and April 2018 Update, the first result count is announced.

Expected behavior:

Emoji is announced.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

Alpha.16477

Windows version:

Windows 10 Version 1809 (build 17763)

Name and version of other software in use when reproducing the issue:

None

Other information about your system:

None

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes - 2018.3, 2018.4

Solution:

In October 2018 Update and later, name change event is fired while emoji search is in progress, with the progress message having a unique automation ID. Thus catch this and announce the top emoji if possible.

Thanks.

josephsl added a commit to josephsl/nvda that referenced this issue Dec 26, 2018

Composable Shell/emoji panel: announce top emoji when searching for o…
…ne. Re nvaccess#9105.

While searching for emojis in Version 1809 and later, name change event is fired by search block text. However, item selection event is also fired, which means only the results count will be announced, not the moji itself. Thus return from name change event if emoji search is under way.

@nvaccessAuto nvaccessAuto added this to the 2019.1 milestone Jan 31, 2019

michaelDCurran added a commit that referenced this issue Jan 31, 2019

Emoji panel: emoji search results, automation ID based event handler,…
… catch attribute error exception when closing the panel (#9112)

* Modern keyboard: update app module description text to include cloud clipboard paste functionality.

* Composable Shell/window open event: use automation ID's to look up which input panel technology should be handled. Re #9104.

Previously NVDA assumed that emoji panel is the only thing to be handled, thus looked up build number and child count. However, it was later discovered that different input panel features expose different automation ID's for various features. Thus use this (along with build number if appropriate) when dealing with different aspects of modern input panel.

* Composable Shell/various events: catch attribute error for several parents and objects, especially when closing emoji panel. Re #9106.

* Composable Shell/emoji panel: handle sking tone modifiers.

In Windows 10 Version 1809 and later, people emoji includes skin tone modifiers. Thus detect this and move to the appropriate emoji when searching for people emoji.

* Composable Shell/emoji panel: announce top emoji when searching for one. Re #9105.

While searching for emojis in Version 1809 and later, name change event is fired by search block text. However, item selection event is also fired, which means only the results count will be announced, not the moji itself. Thus return from name change event if emoji search is under way.

* Update what's new.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.