Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA plays its sound for search suggestions, when going to fullscreen mode and vice versa in the YouTube player in Microsoft Edge #9110

Closed
k-kolev1985 opened this issue Dec 29, 2018 · 7 comments · Fixed by #10200
Milestone

Comments

@k-kolev1985
Copy link

k-kolev1985 commented Dec 29, 2018

Steps to reproduce:

  1. In NVDA's settings -> Object Presentation, enable the option to play a sound when search suggestions appear.
  2. Open Microsoft Edge.
  3. Go to www.youtube.com.
  4. Open a video from the main page (doesn't matter which).
  5. Wait for the video to start playing.
  6. Bypass the "F" key, so it can be send to the YouTube player. This makes the player to go in fullscreen mode.
  7. Bypass the "Escape" key, so you can exit out of fullscreen mode.

Actual behavior:

NVDA plays its sound for available search suggestions each time the YouTube player goes into or exits out of fullscreen mode.

Expected behavior:

NVDA should not play its sound for available suggestions each time the YouTube player goes into or exits out of fullscreen mode, because there are no search suggestions available and in fact we're not working with a search field at all in this case.

System configuration

  • Operating system: Windows 10 Pro version 1809 (build 17763.195), 64-bit, in Bulgarian with all locale settings set to "Bulgarian".
  • NVDA version: alpha-16477,f6cd02d2.
  • Microsoft Edge version: Microsoft Edge 44.17763.1.0, Microsoft EdgeHTML 18.17763.
  • Processor: Intel Core i5-4670 at 3.40GHz.
  • RAM Memory: 8.00GB.
  • Graphics: MSI GeForce GTX-1050TI Gaming X 4G, 4096MB dedicated memory + 4065MB shared system memory, desktop resolution set to 1920x1080.
  • Sound Card: Realtek ALC887 at Intel Lynx Point PCH - High Definition Audio Controller.

Other questions

Does the issue still occur after restarting your PC?

Yes, it does.

Have you tried any other versions of NVDA?

Yes, this issue has been present probably since the feature to play a sound when search suggestions are available was introduced to NVDA.

@josephsl
Copy link
Collaborator

josephsl commented Dec 29, 2018

@josephsl
Copy link
Collaborator

josephsl commented Dec 29, 2018

Hi,

Try today's Windows 10 App Essentials release (19.01.1/December 29th hotfix snapshot) and see if the problem is gone; if it is gone, I'll open a pull request regarding this problem.

Technical: the current Core implementation won't perform focus object comparison when controller for event with controller for count of 0 is detected. The add-on does fix this at the moment.

Thanks.

@k-kolev1985
Copy link
Author

k-kolev1985 commented Dec 29, 2018

I've played a few YouTube videos in fullscreen mode in Edge and the issue did not occur.

@josephsl
Copy link
Collaborator

josephsl commented Dec 29, 2018

@k-kolev1985
Copy link
Author

k-kolev1985 commented Dec 29, 2018

Oops, sorry, I forgot to clarify. Yes, it is with today's snapshot of "Windows 10 App Essentials" - 20181229-dev.

P.S.: Sorry, closed it by mistake and that is why I've reopened it.

@josephsl
Copy link
Collaborator

josephsl commented Jul 30, 2019

Hi,

Coming back to this...

I have figured out a more reliable way to resolve this problem (and many others involving controller for event issue with address bar not in focus). However, in order to resolve this, @leonardder's UIA auto select work must be included, as Edge's address omnibar is one of those that can benefit from his work.

Technical: the reliable way to resolve this is assigning an overlay class to Edge's address omnibar so that search suggestion sound won't play if the control is not focused.

Thanks.

@josephsl
Copy link
Collaborator

josephsl commented Jul 31, 2019

Hi,

Actually, a more long-term solution is telling NVDA to exclude Edge address omnibar from participating in controller for event i.e. remove it from search field lookup. Not only this resolves this issue, it also allows consistency between Edge and other web browsers/edit fields where auto-select is used.

I'll create a new issue that generalizes this to other situations.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants