Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In MS Excel elements list formulas are always reported in English regardless of the Excel language. #9144

Closed
lukaszgo1 opened this issue Jan 12, 2019 · 4 comments · Fixed by #11329
Milestone

Comments

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented Jan 12, 2019

Steps to reproduce:

  1. Start Microsoft Excel in language other than English.
  2. Write some formula in the Excel interface language for example =today().
  3. Open elements list and switch to formulas.

Actual behavior:

The formula is shown as '=TODAY()'.

Expected behavior:

The formula should be shown in the language in which it was entered for example for Polish version of Excel '=DZIŚ()'.

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-16458,5e710dac

Windows version:

Windows 7 x64

Name and version of other software in use when reproducing the issue:

Microsoft Excel 2010 32-bit in Polish

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes 2018.1 and the problem is present there. I believe it worked correctly in the past, but cannot recall with which version.

@JulienCochuyt
Copy link
Collaborator

JulienCochuyt commented Jul 3, 2020

@lukaszgo1 wrote:

Have you tried any other versions of NVDA?

Yes 2018.1 and the problem is present there. I believe it worked correctly in the past, but cannot recall with which version.

At first glance, it seems the way the formula is retrieved has not changed since contribution by @dineshkaushal in 2015.2 as of 06ab8e4, although there of course might be side effects I hadn't considered.
Could you please check with older versions of NVDA to ensure localized formulas used to be retrieved and hopefully identify when it turned to English only?

Note: I'm not arguing at all this should be fixed only if it is a regression, I'm convinced this is an issue for any user of non-English locales.

@JulienCochuyt
Copy link
Collaborator

JulienCochuyt commented Jul 3, 2020

@michaelDCurran this one was an easy fix, as the range object exposes a "FormulaLocal" property, if I recall correctly.
However, since #9257, it's a whole other story...
Would you know whether there is an equivalent to XLDISPID_RANGE_FORMULA for localized formulas?
Or maybe just point to the relevant documentation on the used Excel IDispatch DISPIDs?

@michaelDCurran
Copy link
Member

michaelDCurran commented Jul 3, 2020

@JulienCochuyt
Copy link
Collaborator

JulienCochuyt commented Jul 3, 2020

@michaelDCurran: Thank you! Quick, clear, informative.

@lukaszgo1: No need to bother checking earlier versions. PR on its way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants