Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functionality #9548

Closed
leonardder opened this issue May 8, 2019 · 13 comments
Closed

Remove deprecated functionality #9548

leonardder opened this issue May 8, 2019 · 13 comments
Assignees
Labels
goodForNewDev Python 3
Milestone

Comments

@leonardder
Copy link
Collaborator

@leonardder leonardder commented May 8, 2019

Is your feature request related to a problem? Please describe.

The introduction of Python 3 and SPeech Refactor will introduce backwards incompatible changes.

Describe the solution you'd like

As one of the goals is to bundle all backwards incompatible changes as much as possible, I propose removing all functionality that is considered deprecated. This includes:

  • Directly importing validate instead of configobj.validate
  • textInfos.Point and textInfos.Rect should utilize locationHelper instead
  • braille.BrailleHandler._get/set_tether
  • config.getConfigDirs
  • config.ConfigManager.getConfigValidationParameter
  • inputCore.InputGesture.logIdentifier property
  • synthDriverHandler.SynthDriver.speakText/speakCharacter, when they survives speech refactor

Describe alternatives you've considered

Just leave the code as is.

@leonardder leonardder added goodForNewDev Python 3 labels May 8, 2019
@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented May 8, 2019

@josephsl
Copy link
Collaborator

@josephsl josephsl commented May 8, 2019

@josephsl
Copy link
Collaborator

@josephsl josephsl commented May 8, 2019

@Brian1Gaff
Copy link

@Brian1Gaff Brian1Gaff commented May 8, 2019

@lukaszgo1
Copy link
Contributor

@lukaszgo1 lukaszgo1 commented May 10, 2019

@josephsl wrote:

Hi, we might as well remove app modules that are no longer relevant – I know there will be at least one protester, but some app modules are no longer relevant, especially after dropping support for anything earlier than Windows 7 SP1.

I've looked through all appModules and only candidate for removal seems to be sndrec32 which is present only in Windows XP.
At first I've found 2 more possible and decided to research further

  1. Module for Outlook Express- this one is still used even in Windows 10
  2. Module for MSN Messenger - while it officially is EOL there is still a patch allowing it to work and a server to which you can connect with it.

To make myself clear I am not saying that these modules should be improved in any way but we shoudl simply keep the as is. There is no point in removing functionality. The Python 3 and speeech refactor would put off enough user as is and we should do everything possible not to make last Python 2 NVDA version the next Windows XP.

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented May 11, 2019

How about the following appModules?

  • aim
  • teamtalk3
  • teamtalk4classic
  • Klango

@xingkong013
Copy link
Contributor

@xingkong013 xingkong013 commented May 16, 2019

How about the following Modules?
txt2tags
Reason for deletion:
The current txt2tags official has not been updated for a long time.
Alternatives:
You can use the markdown, or poedit plus markdown to translate the user guide and update the log.
thank

@josephsl
Copy link
Collaborator

@josephsl josephsl commented May 16, 2019

@xingkong013
Copy link
Contributor

@xingkong013 xingkong013 commented May 16, 2019

hello leonardder
I have two ideas
The first is to use python official to first convert the user guide and log into sphinx and then generate the .po file. At this time, the translator can use the poedit editor to translate the specific syntax. You don't need to export the .html file. Use the poedit editor to export to HTML functionality
The second idea is to use poedit plus markdown to manage the translation. First, convert the user guide and update log to the markdown. Then, when converting the markdown to the .po file, the translator directly translates it directly with the poedit editor. If you want to generate a web page, you can use the poedit editor to export to HTML.
thank

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented May 18, 2019

I started working on this on my deprecate branch.

@leonardder leonardder self-assigned this May 18, 2019
@josephsl
Copy link
Collaborator

@josephsl josephsl commented May 18, 2019

Hi,

I'll work on code consistency edits (winUser.FindWindow -> findWindow, for example), destined for a separate issue.

Thanks.

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented May 31, 2019

@leonardder now that the PR above has been merged. Is this issue fixed? Or is there any further work to be done?

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Jun 28, 2019

Fixed in #9603

@feerrenrut feerrenrut removed this from the 2019.2 milestone Jul 30, 2019
@feerrenrut feerrenrut added this to the 2019.3 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goodForNewDev Python 3
Projects
None yet
Development

No branches or pull requests

8 participants