-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review cursor: don't report "top"/"bottom" message when moving on the first/last line of the current object #9551
Comments
… first/last line of the current object Fixes nvaccess#9551
Please outline actual steps to reproduce, eg which application which control what text. This helps to ensure everyone is talking about the same thing.
I suspect there are a few reasons for this behaviour:
Before we can make a change here, we should get more information from the community. |
I have had a chat to @michaelDCurran about this. We have agreed that it is ok to remove "top" and "bottom" from We realised that Still, please update the description on this issue to explain the details more clearly. |
…tOfLine and script_review_endOfLine See nvaccess#9551 (comment)
Hi. Pardon my confusion, but I still see this being reported. As I type this, if I press Numpad 3, I hear right, followed by blank. This issue, therefore, needs further explanation, especially if this is still no longer intended. I'm using NVDA 2020.2beta2. |
This issue was specific to the move to top / move to bottom scripts for review cursor. These no longer redundantly announce "top" and "bottom". The messages are not required in these scenarios as it is obvious to the user that they hit the top / bottom because they deliberately went there. However, the other review scripts (previs and next line/word/char) still say these messages if you try to move past the edge of the text. If users also want the messages removed in that those scenarios, a new issue should be opened. |
Hi.
I see that now, and fully understand what is being solved here. However,
the wording in the What's New does not match what is being said here, and
requires a more specific explanation. Perhaps this can work to replace both
entries:
•NVDA no longer reports "top", "bottom", "left" or "right" messages when
an input gesture is used to directly move the review cursor to the first or
last line or character of the current navigator object. (#9551)
…On Thu, Jun 25, 2020 at 8:00 PM Michael Curran ***@***.***> wrote:
This issue was specific to the move to top / move to bottom scripts for
review cursor. These no longer redundantly announce "top" and "bottom". The
messages are not required in these scenarios as it is obvious to the user
that they hit the top / bottom because they deliberately went there.
However, the other review scripts (previs and next line/word/char) still
say these messages if you try to move past the edge of the text. If users
also want the messages removed in that those scenarios, a new issue should
be opened.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9551 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGI5SN3COI53MB5V4CPNTTRYPXKBANCNFSM4HL35HQQ>
.
|
I agree. Thanks for the corrected wording here.
|
Steps to reproduce:
Press NVDA+Control+home / NVDA+Control+end in laptop layout. Or shift+numpad7 / shift+numpad9 in desktop layout.
Actual behavior:
NVDA reports (through speech and braille) "top" or "bottom" flash message, then reports the line.
Expected behavior:
NVDA should just reports the line.
Note: I work with command line a lot and I often use these commands. In my opinion, these flash messages are painful, especially in braille. I'd suggest to remove them.
System configuration
NVDA installed/portable/running from source:
Any
NVDA version:
Any
Windows version:
N/A
Name and version of other software in use when reproducing the issue:
N/A
Other information about your system:
N/A
Other questions
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
Yes, same behavior.
The text was updated successfully, but these errors were encountered: