Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review cursor: don't report "top"/"bottom" message when moving on the first/last line of the current object #9551

Closed
aaclause opened this issue May 9, 2019 · 6 comments · Fixed by #9553
Milestone

Comments

@aaclause
Copy link
Contributor

aaclause commented May 9, 2019

Steps to reproduce:

Press NVDA+Control+home / NVDA+Control+end in laptop layout. Or shift+numpad7 / shift+numpad9 in desktop layout.

Actual behavior:

NVDA reports (through speech and braille) "top" or "bottom" flash message, then reports the line.

Expected behavior:

NVDA should just reports the line.

Note: I work with command line a lot and I often use these commands. In my opinion, these flash messages are painful, especially in braille. I'd suggest to remove them.

System configuration

NVDA installed/portable/running from source:

Any

NVDA version:

Any

Windows version:

N/A

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, same behavior.

@feerrenrut
Copy link
Member

feerrenrut commented May 13, 2019

Please outline actual steps to reproduce, eg which application which control what text. This helps to ensure everyone is talking about the same thing.

def script_review_previousLine also announces "top" when the top line is reached. It helps to have this behaviour to differentiate between multiple equal lines, and reaching the limit of the object.

I suspect there are a few reasons for this behaviour:

  • help to orient users after a change in position.
  • to have symmetrical behaviour with script_review_previousLine

Before we can make a change here, we should get more information from the community.

@feerrenrut
Copy link
Member

feerrenrut commented May 14, 2019

I have had a chat to @michaelDCurran about this.

We have agreed that it is ok to remove "top" and "bottom" from script_review_top and script_review_bottom. However, to keep these the behaviour symmetrical with the left / right commands, then "left" and "right" should be removed from script_review_startOfLine and script_review_endOfLine

We realised that script_review_previousLine requires "top" to be announced when the script is triggered but the position does not change, in order to be able to differentiate encountering repeated lines from hitting the top boundary. This is not the case for script_review_top since it will always move to the top, and the behaviour is not different on subsequent calls.

Still, please update the description on this issue to explain the details more clearly.

aaclause added a commit to aaclause/nvda that referenced this issue May 14, 2019
feerrenrut pushed a commit that referenced this issue Jun 11, 2020
Fixes #9551
For the review cursor.
Don't report "top"/"bottom" message when moving on the first/last line of the current object
Also remove "left"/"right" from script_review_startOfLine and script_review_endOfLine

Update changes file for PR #9553
Co-authored-by: Reef Turner <reef@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2020.2 milestone Jun 11, 2020
@fisher729
Copy link

fisher729 commented Jun 25, 2020

Hi.

Pardon my confusion, but I still see this being reported. As I type this, if I press Numpad 3, I hear right, followed by blank. This issue, therefore, needs further explanation, especially if this is still no longer intended. I'm using NVDA 2020.2beta2.

@michaelDCurran
Copy link
Member

michaelDCurran commented Jun 26, 2020

This issue was specific to the move to top / move to bottom scripts for review cursor. These no longer redundantly announce "top" and "bottom". The messages are not required in these scenarios as it is obvious to the user that they hit the top / bottom because they deliberately went there. However, the other review scripts (previs and next line/word/char) still say these messages if you try to move past the edge of the text. If users also want the messages removed in that those scenarios, a new issue should be opened.

@fisher729
Copy link

fisher729 commented Jun 26, 2020

@michaelDCurran
Copy link
Member

michaelDCurran commented Jun 26, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants