Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling ARIA 1.1 Combobox is broken in Chrome and Firefox #9616

Closed
mshoho opened this issue May 24, 2019 · 7 comments · Fixed by #10046
Closed

Handling ARIA 1.1 Combobox is broken in Chrome and Firefox #9616

mshoho opened this issue May 24, 2019 · 7 comments · Fixed by #10046
Assignees
Labels
Milestone

Comments

@mshoho
Copy link

@mshoho mshoho commented May 24, 2019

ARIA 1.0 combobox role should be applied to <input>, but ARIA 1.1 combobox role is being applied to a container.

NVDA seems to handle ARIA 1.0 comboboxes ok. But handling ARIA 1.1 comboboxes is broken:

  1. In Browse mode NVDA just skips the combobox and its entire contents including <input> inside the container with role=combobox.
  2. I can use Tab to focus the <input> inside the container with role=combobox, but when that <input> has focus, switching between Browse/Focus modes doesn't work.
  3. The Next Combobox shortcut doesn't work as well (saying «no next combobox»).

The reference example: https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html.

Installed NVDA 2019.1.1, Windows 10.

I am currently reproing it in Chrome Version 74.0.3729.169 (Official Build) (64-bit) and in Firefox 67.0 (64-bit).

@DrSooom
Copy link

@DrSooom DrSooom commented May 24, 2019

@mshoho: Please add all webbrowsers (incl. version), where this issue occurs, to the issue description. Thanks.
CC: @jcsteh and @MarcoZehe

@mshoho
Copy link
Author

@mshoho mshoho commented Jun 3, 2019

I am currently reproing it in Chrome Version 74.0.3729.169 (Official Build) (64-bit) and in Firefox 67.0 (64-bit).

@Adriani90
Copy link
Collaborator

@Adriani90 Adriani90 commented Jun 3, 2019

cc: @jcsteh is this exposed accordingly by Firefox? I think there was a discussion about this in another issue but I cannot find it just now.

@jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Jun 4, 2019

Firefox exposes this correctly as far as I can see. This will require some changes to NVDA.

@jcsteh jcsteh added the ARIA label Jun 4, 2019
@PigeardSylvain
Copy link

@PigeardSylvain PigeardSylvain commented Jun 5, 2019

I tried adding a tabindex="0" attribute on the div with combobox role. It's better but it till not work as it should. It's not possible to type text into the input.
I also tried to add the input id in the aria-controls attribut, same result.

@RichCaloggero
Copy link

@RichCaloggero RichCaloggero commented Jun 27, 2019

The only thing that seems broken about the 1.1 combobox in Firefox is that it never announces "combobox" when textbox gains focus. Try the official w3c examples here:

https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

They seem to work well in Firefox with the above noted exception.

@mshoho
Copy link
Author

@mshoho mshoho commented Jun 28, 2019

The only thing that seems broken about the 1.1 combobox in Firefox is that it never announces "combobox" when textbox gains focus. Try the official w3c examples here:

https://www.w3.org/TR/wai-aria-practices/examples/combobox/aria1.1pattern/listbox-combo.html

They seem to work well in Firefox with the above noted exception.

No. I have just specifically upgraded Firefox to 67.0.4 and retested. The combobox is skipped in the browse mode, the focus/browse mode switching doesn't work when the input of the combobox has focus, next combobox shortcut (C) says «no next combobox».

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants