Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when activating document review and review cursor isn't following focus review cursor always ends up at the top of the document. #9622

Closed
lukaszgo1 opened this issue May 27, 2019 · 2 comments · Fixed by #11376
Milestone

Comments

@lukaszgo1
Copy link
Contributor

lukaszgo1 commented May 27, 2019

Is your feature request related to a problem? Please describe.

When pressing NVDA+numpadMinus to move review cursor and navigator object to the position of the caret/focus respectively and the caret is inside the browse mode document navigator object/review cursor ends up at the position of the last focused object not at the caret position.
This is mainly problematic in two cases:

  1. In long pdf's when there is no focusable objects - just a big amount of text - in this case review cursor ends up at the top of the document.
  2. After "focus focusable elements in browse mode" has been set to disabled the focused element is a browser window hence moving navigator object to your position in browse mode is not possible.

Describe the solution you'd like

When moving navigator object to focus take into account position of the browse mode caret and set review cursor there - this would be consistent with other cases e.g. setting position of the review cursor in other editable text fields.

Describe alternatives you've considered

None

Additional context

This is especially annoying for people who have set their review cursor not to follow caret - in this case it is impossible to set the mouse to your browse mode position without navigating to it with object nav from the top of the webpage.

@feerrenrut
Copy link
Member

feerrenrut commented Jul 7, 2020

The current description for this command is:

Sets the navigator object to the current focus, and the review cursor to the position of the caret inside it, if possible

I agree that the user intent that you highlight is likely to be more common than moving to focus. Moving to virtual caret was effectively how this worked previously. However, since there may be cases where the focus is of interest specifically, this should be introduced as a new command.

Given that this use case has regressed with the introduction of #11190, I will accept this into the 2020.3 release unless #11190 gets reverted for some reason.

  • Please start with a PR introducing a new command with no default gesture.
  • As a follow-up PR we can this new command becoming the default for for the NVDA+numpad minus gesture.

@lukaszgo1
Copy link
Contributor Author

lukaszgo1 commented Jul 7, 2020

@feerrenrut wrote:

The current description for this command is:

Sets the navigator object to the current focus, and the review cursor to the position of the caret inside it, if possible

I agree that the user intent that you highlight is likely to be more common than moving to focus. Moving to virtual caret was effectively how this worked previously.

No, this command never moved review cursor to the position of the browse mode caret.

However, since there may be cases where the focus is of interest specifically, this should be introduced as a new command.

I'm afraid I don't follow here:

  • Outside of browse mode this command always moves to focus and if the object with focus has caret sets review cursor to its position.
  • In browse mode after Disable "automatically set focus to focusable elements" by default #11190 either a browser window has focus because user navigates with the browse mode caret only (I really don't see any use case for moving review cursor to it) or some random object which was focused previously - again what is the point of moving to it specifically.

The regression here is the fact that for people for whom review cursor doesn't follow browse mode caret it is impossible to move object nav to the current position in browse mode. In all other places this is accomplished by NVDA+Numminus and I'm afraid introducing new command just for browse mode would be extremely confusing.

lukaszgo1 added a commit to lukaszgo1/nvda that referenced this issue Jul 14, 2020
…cument

set review cursor to the position of the browse mode caret/
Fixes nvaccess#9622
feerrenrut pushed a commit that referenced this issue Jul 21, 2020
…. (PR #11376)

When moving review cursor to focus in browse mode it is now set at the position of the virtual caret.
Closes #9622
Previously the navigator object may have been set to the document or some other object.
Co-authored-by: Reef Turner <reef@nvaccess.org>
@nvaccessAuto nvaccessAuto added this to the 2020.3 milestone Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants